Remove php short open tag from theme tpl's

christopher_skauss - September 11, 2008 - 15:25
Project:Nodereferrer Create
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Hello and thanks for this great module!
I have php configured to not allow short open tags, as for many is the case, and on the 'create related content' page I get nothing. I found nodereferrer-create-inline-menu.tpl.php and nodereferrer-create-menu.tpl.php using short open tags and corrected them. Even then, to see the 'create new' button I had to set 'Use a javascript popup rather than a redirect for the local task' to unchecked. Any ideas why?
Thanks!

#1

Anselm Heaton - September 19, 2008 - 09:11

Hi, sorry I didn't reply earlier - I'm not the module owner (but I did the D6 version), so issues here don't show in my own issue page. I'll try and remember to come here more often.

  1. Sorry about the PHP tags ! My hands obviously did the thinking for me there.... I've just committed a version without short tags ; should be available as a package within 12 hours.
  2. Menu issue
    1. What browser are you using ?
    2. I assume you have javascript enabled ?
    3. The problem is that you see the 'Create Related Content' local task, but that clicking on it does nothing ?
    4. Do the small popups themselves work ?
    5. If you are using FF, can you check (after loading the page) if there are Javascript errors ? And after clicking on 'Create Related Content' ? Could you send the error message if any ?

Glad you like the module :)

#2

Anselm Heaton - September 19, 2008 - 09:12
Status:active» postponed (maintainer needs more info)

Changing status to needs more info.

#3

christopher_skauss - September 19, 2008 - 17:52

Thanks for looking into this!
I am using Firefox 3 with javascript enabled, no error whatsoever, and I get no popups at all. When I click on the "create new *content*" arrow, I am redirected to a create node page which works well but it is not a popup. This is not really an issue for me, as I like the functionality already but it would be nice to troubleshoot this for other users.

#4

Anselm Heaton - September 25, 2008 - 09:21

Thanks christopher. I've tried with FF3 on another machine but it works with my test site.

The module does something pretty lame [*] to find which the 'Create Related Content' menu is, which I've reported as a separate issue here http://drupal.org/node/312807 ; if your URL isn't the clean, verbatim drupal URL this might be the cause of what your are seeing.

Do you have clean URLs enabled ? Do you add any prefix to the URL, such as language code ? Can you paste what the URL is when you are viewing the page ? And (if you are at ease doing this, don't worry if it feels like a hassle) can you look at the HTML and paste the code of the link to Create Related Content ? It should look something like this :

<a href="/node/554/nodereferrer_create_content" id="menu-node05540nodereferrer0create0content">Create related content</a>

[*] In my own code of course, which is why I'm allowed to say it's crap :)

#5

christopher_skauss - September 28, 2008 - 00:26
Status:postponed (maintainer needs more info)» closed

Dear Anselm, the url I am using is rather different from a usual one, being that I am running the web server locally, and I have a structure such as: http://localhost/websitename.tld/ as website root. However I have tried the latest release and it seems to be running fine! So thank you for looking into this!

 
 

Drupal is a registered trademark of Dries Buytaert.