Replace actions_aid table with variable

Posted by Dave Reid on September 12, 2008 at 12:18am

Issue Summary

Currently, the entire purpose of the {actions_aid} table is to store the last {actions}.aid inserted into the {actions} table. One field, one purpose which seems like it should be able to easily be replaced with a variable or a simple query of the {actions} table. I'm working on getting a patch written.

Comments

#1

Posted by Dave Reid on September 12, 2008 at 1:04am

Title:	Remove unnecessary actions_aid table	» Replace actions_aid table with variable or actions table query
Status:	active	» needs review

Initial patch using variable replacement with upgrade path provided. I left in a commented, alternative method using a query of the actions table, but I haven't tested it yet to see if it would be compatible with different databases and my gut instinct says it won't be. I left it just in case so if someone could possibly improvement.

Attachment	Size	Status	Test result	Operations
307259.actions_aid_table.patch	2.74 KB	Ignored: Check issue status.	None	None

#2

Posted by Dave Reid on September 23, 2008 at 8:04pm

Title:

Replace actions_aid table with variable or actions table query

» Replace actions_aid table with variable

After review, it would be easiest to replace the actions_aid just with a variable. Update worked successfully, and passed actions configuration test 100% after a patched update and on patched fresh install.

Not really loving the fact that we don't have some definitive DBTNG documentation...

Attachment	Size	Status	Test result	Operations
actions_aid_table.patch	2.46 KB	Ignored: Check issue status.	None	None

#3

Posted by chx on September 24, 2008 at 1:27am

Status:

needs review

» needs work

You would introduce a race condition with this patch. The beauty of auto_increment is that it's atomic.

#4

Posted by Dave Reid on September 24, 2008 at 4:44am

Thanks for pointing that this was heading in the wrong direction. I'm playing around with making the aid column of the actions table an md5 value of (callback + parameters + description) for all actions. Doing that will get rid of the actions_aid table and seems like it might make some of the actions code a little less complicated.