Revive Jabber [#30727]

Google (Talk) uses Jabber and that alone is enough reason to dust off Jabber and put it back into core. If you are looking for a maintainer, my hand is up.

The only significant code change is that I removed the global $jabber; because I have not liked that.

I included an exception for gmail.com. If you do not like it, then do not commit the module as there is almost no point.

Comment	File	Size	Author
#1	jabber_0.txt	4.62 KB	chx
	jabber.txt	4.59 KB	chx

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

chx CreditAttribution: chx commented 8 September 2005 at 22:54

File	Size
jabber_0.txt	4.62 KB

drumm says that I left in b and i tags. That's Bad. Also he asked why I have not changed $server for gmail. One, the port would need a change, so this is shorter, two (as he noted later) the variable is reused.

Comment #2

walkah CreditAttribution: walkah commented 8 September 2005 at 23:00

i'm actually gearing up to commit a jabber.module that re-instates the dist-auth component... as well as some other features (like status, send message, etc) ... any reason why this needs to be in core?

Comment #3

chx CreditAttribution: chx commented 8 September 2005 at 23:01

Yes. Anyone with a gmail account has a drupal account.

Comment #4

walkah CreditAttribution: walkah commented 8 September 2005 at 23:10

to reiterate from IRC:

to do this just for gmail is bad because:
* talk.google.com requires TLS (which you haven't implemented)
* special casing is ugly that's what DNS SRV is for
* drupal dist-auth isn't all that secure anyway (as previously noted)... inviting gmail users to divulge their password in all drupal sites is... well... not a good idea imo.

a big -1 from me, sorry :(

Comment #5

chx CreditAttribution: chx commented 8 September 2005 at 23:12

Status:

Needs review

» Needs work

Alas, the module is wrong -- i have only tested with correct password but let's me in to Drupal with incorrect. Would need TLS but seems not to work with that.