Google (Talk) uses Jabber and that alone is enough reason to dust off Jabber and put it back into core. If you are looking for a maintainer, my hand is up.

The only significant code change is that I removed the global $jabber; because I have not liked that.

I included an exception for gmail.com. If you do not like it, then do not commit the module as there is almost no point.

CommentFileSizeAuthor
#1 jabber_0.txt4.62 KBchx
jabber.txt4.59 KBchx

Comments

chx’s picture

chx commented
StatusFileSize
new jabber_0.txt4.62 KB

drumm says that I left in b and i tags. That's Bad. Also he asked why I have not changed $server for gmail. One, the port would need a change, so this is shorter, two (as he noted later) the variable is reused.

walkah’s picture

walkah commented

i'm actually gearing up to commit a jabber.module that re-instates the dist-auth component... as well as some other features (like status, send message, etc) ... any reason why this needs to be in core?

chx’s picture

chx commented

Yes. Anyone with a gmail account has a drupal account.

walkah’s picture

walkah commented

to reiterate from IRC:

to do this just for gmail is bad because:
* talk.google.com requires TLS (which you haven't implemented)
* special casing is ugly that's what DNS SRV is for
* drupal dist-auth isn't all that secure anyway (as previously noted)... inviting gmail users to divulge their password in all drupal sites is... well... not a good idea imo.

a big -1 from me, sorry :(

chx’s picture

chx commented
Status: Needs review » Needs work

Alas, the module is wrong -- i have only tested with correct password but let's me in to Drupal with incorrect. Would need TLS but seems not to work with that.

markus_petrux’s picture

markus_petrux commented
Priority: Critical » Normal

I guess this is not so critical...

chx’s picture

chx commented
Status: Needs work » Closed (fixed)