Usability: Make comment text consistent

In 7.x, this discrepancy still exists.

The default comment link is titles 'Add new comment', while the comment form page is titled 'Reply to comment' and the actual comment form is titled 'Reply'

These three elements need to be made consistent with one another.

I would propose 'Add a new comment' as a good replacement for all three. I've attached a patch to implement that; of course, alternate suggestions are encouraged.

Also tagging for Usablity.

Looks good to me, also aligns well with 'Add new content' - is there a problem using 'Add new comment' everything though and skipping the 'a'?

No problem. Just 'Add a new comment' makes better grammatical sense then 'Add new comment'.

If the concensus is that it should be changed, I will.

"Add a new comment" doesn't flow as fast as "Add new comment". Can we standardize on "Add new comment" first, and then debate the "a" as a follow-up -- can be done in the same issue.

New patch with 'Add new comment' across the board.

Committed this patch. Let's keep discussing the 'a' now.

I don't know how much discussion is needed, since there isn't a 'right' way and a 'wrong' way.

'Add new comment' does indeed flow better as you pointed out. 'Add a new comment' seems a little more 'correct'.

However, it's not a big enough deal to make it worth patching. The purpose is clearly communicated in both strings, so I am happy enough just leaving it as it is.

Since BrianV is happy with the change as is I'm going to mark this to fixed.

Woot, woot! I filed this issue in Nov. '07 (http://drupal.org/node/189659) and a discussion went back and forth with different possibilities that didn't coalesce before code froze for 6.... 42 posts in all. But here, just 9 posts and three days, and voila -- a commit for 7! Sometimes the world is just ready for something, no hassle necessary :)

Thanks for all the great work brianV, Dries, and catch.

Shai