xmlrpc test for big messages.

xmlrpc_test_message_sized_in_kb($size) sounds better

Few format issues and clearness changes (#2 included) (minor changes):

• messageSizedInKB -> messageSizedInKB
• xmlrpc_test_message_sized_in_k -> xmlrpc_test_message_sized_in_kb
• Removed extra white-space (you can use regex [ ]+$ or your editor if it has it.)
• Comments start with capital and end with period.
• Other formatting issues.

Test passes:
3 passes, 0 fails, 0 exceptions

Test looks good I think it is ready to go. A few more formatting fixes and added comments.

I think it ready to go.

The patch still has coding style issues (i.e. incorrect spacing after commas). I'd also write XML-RPC in PHPdoc, rather than xmlrpc.

Fixed a period and one extra space.

I think it looks fine. (thine eyes != perfect)

+ * @param $size Message size in KB.
+ * @return array Generated message structure.
...
+   * @param $message_size Size of message in KB.

Needs to be consistent with other PHPDoc, which is to put the param on one line, the description on the next.

+  for($i = 0 ; $i < 128; $i++) {

needs a space between for and (

+    // Almost 1KB block.

Sorry? I don't parse this comment.

+  function sizedMessage($message_size) {

The point of this function isn't clear from its name; would help if there was a verb there. But it's weird to have a layer of indirection between the testX function and the assertions. I get that you're trying to avoid duplication of code, but what if we did something like this intead:

function testSizedMessages() {
  $sizes = array(8, 80, 160);
  foreach ($sizes as $size) {
    // Test the size here.
  }
}

Removed some extra line spacing and added a period to comment.

Awesome, thank you!

I just made one little tweak which was to move...

+      $xml_url = url(NULL, array('absolute' => TRUE)) . 'xmlrpc.php';

...outside of the foreach loop, since it's not dependent on $size.

Committed. Thanks!