Date formatting function

the last one contains all?

cl-k@web3:~/web/modules/token$ patch < token6_1.patch 
(Stripping trailing CRs from patch.)
patching file token.module
patch: **** malformed patch at line 49:  

No, I think it is Ubuntu.

I'll try to add it manully

works

Oh, i meant the patch, I review it tommorow

I dont the the seconds, minutes and hours to show up wgen trying to set the submitted by text

I don't think this should be in token.module. The place for node tokens is in token_node.inc, which is what #323441 add timestamp tokens (g, G, h, H, i, s, U) for hours, minutes and seconds targets.

But since I need tokens for hours minutes and seconds they need t be created dont they?

Is that hard to make?

But how to transfer that into token_comments?

what's the status here?

@lomz(#19):
"But how to transfer that into token_comments?"

<?php
$values['comment-yyyy']            = date('Y', $comment->timestamp);
$values['comment-yy']              = date('y', $comment->timestamp);
$values['comment-month']           = date('F', $comment->timestamp);
$values['comment-mon']             = date('M', $comment->timestamp);
$values['comment-mm']              = date('m', $comment->timestamp);
$values['comment-m']               = date('n', $comment->timestamp);
$values['comment-ww']              = date('W', $comment->timestamp);
$values['comment-date']            = date('N', $comment->timestamp);
$values['comment-day']             = date('l', $comment->timestamp);
$values['comment-ddd']             = date('D', $comment->timestamp);
$values['comment-dd']              = date('d', $comment->timestamp);
$values['comment-d']               = date('j', $comment->timestamp);
?>

becomes

<?php
$values += token_date_values($comment->timestamp, 'comment');
?>

(array keys are all strings, so this array arithmetics should work)

@NancyDru:
I don't see hours and minutes and seconds in your patch..

I don't see hours and minutes and seconds in your patch..

Those are proposed by another patch (#323441: add timestamp tokens (g, G, h, H, i, s, U) for hours, minutes and seconds). Perhaps the two different issues should be merged.

Hi, issue with time function on token_node.inc, line 48, latest version.

date() [<a href='function.date'>function.date</a>]: It is not safe to rely on the system's timezone settings. Please use the date.timezone setting, the TZ environment variable or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier. We selected 'Europe/Berlin' for 'CET/1.0/no DST' instead

Greetings, Martijn

Here's the patch I had made up before I even saw this issue to help reduce even more code.

Patch applies with slight offset with token_node.inc. Looks good to me.

use format_date (#433486: Use format_date() for translatable date tokens)

Committed to CVS. Thanks everyone!
http://drupal.org/cvs?commit=340220