This patch fixes the text-alignment in modal windows to be left for LTR readers.

If you read text this is much better from readability and usability side.

CommentFileSizeAuthor
D5_panels_fix_text-alignment_in_modal_window.patch640 byteshass

Comments

dellintosh’s picture

dellintosh commented
Status: Needs review » Reviewed & tested by the community

Applied patch. Tested layout. Does improve readability/accessibility by moving form elements in better alignment to their labels.

Looks good! :)

dellintosh’s picture

dellintosh commented
Version: 5.x-2.x-dev » 5.x-2.0-rc1a
sdboyer’s picture

sdboyer commented
Status: Reviewed & tested by the community » Needs work

I get the first (text-align), but not the second one. Why do we eliminate width and add padding-right instead?

hass’s picture

hass commented
Status: Needs work » Reviewed & tested by the community

1. The width is mostly to big in size and moves the input boxes too far to the right side.
2. The padding is only to make the label not sticking on/under the modal window border. The label doesn't look nice without and flows "under" the border - out of the modal window. That's all... not related to the width change.

It would be helpful if you could say what "needs work" if you think it needs work. THX.

sdboyer’s picture

sdboyer commented
Status: Reviewed & tested by the community » Fixed

I disagree that it moves the input boxes too far to the right. Your approach makes some other boxes line up badly - ones which line up nicely now. So I'm committing the text align change, but not the width or padding change.

I asked for justification on a change and simultaneously marked the issue 'needs work.' That's self-explanatory. The real mystery here is when it became OK to say a patch does one thing in the issue description, but have it throw other things in there, too.

THX.

hass’s picture

hass commented

Hm - I thought it is clear that the UI of panels 2.x needs much usability love to be self explanatory and looking good. I will take a look and may upload some screenshot that make clear what I'm talking about with the width and padding.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.