flexinodes uses drupal_not_found() as it would exit after doing its job. but that isn't the fact.
so i recently ran in an endless lopp of not_found-pages.

patch for 4.6 is attached.
but as it isn't a too complicated patch, it might do the job for head too.

CommentFileSizeAuthor
#5 30792.patch.txt8.9 KBBèr Kessels
flexinode-notfound.patch946 bytesfago

Comments

Bèr Kessels’s picture

Bèr Kessels commented
Status: Needs review » Reviewed & tested by the community

Code looks good, But where did you run into that loop? On what page(s)?

fago’s picture

fago
Primary language German
Location Vienna
commented

i think it was on a list page with a not existing ctype_id.

Bèr Kessels’s picture

Bèr Kessels commented

I am willing to commit this, but I need to evaluate it first. in order to do so, i really need to know if, how and where to reproduce the issue.

fago’s picture

fago
Primary language German
Location Vienna
commented

i couldn't reproduce the loop
(i think, i had pointed to an not existing notfound-document -> loop)

however:
going to flexinode/list will end up in two theme_page()s, the notfound document and afterwards a list of all flexinode items - the code afterwards seems to take care of this case.

going to flexinode/table and flexinode/search shows the same (2 pages..), however the code of the second page doesn't look like being meaningfully for no ctype_id.

Bèr Kessels’s picture

Bèr Kessels commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 30792.patch.txt8.9 KB

This is a better appraoch IMO.

please test.

Bèr Kessels’s picture

Bèr Kessels commented
Version: 4.6.x-1.x-dev » master
samc’s picture

samc commented

Reads clean and tests fine for me.

+1

Bèr Kessels’s picture

Bèr Kessels commented
Status: Needs review » Fixed

committed.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)