Two minor tweaks

salvis - September 13, 2008 - 12:02
Project:Mail editor
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

Since you now maintain a {mail_edit_registry} table, I'd like you to join the {mail_edit} table with the registry before retrieving the rows for building the admin/build/mail-edit page. This will allow other modules to store additional template pieces in {mail_edit}, instead of having to create their own table with only a record or two and having to maintain two different access mechanisms.

Also, I'd like to be able to use %variables like

$mailkeys['node-nid'] = t('Notifications for %Pages subscriptions', array('%Pages' => t('Pages')));

for the descriptions. This doesn't work so well when the user tries to edit the descriptions (they contain <em> tags). So I'd remove the tags before placing the description strings into the description edit field. This means the user will lose the emphasizing, but at least he had it when the mailkey first showed up.

The attached patch makes these two changes.

AttachmentSize
mail_edit.patch1.29 KB

#1

litwol - September 13, 2008 - 14:47

Do you intend to add those requested features as part of this patch later on ? i'm asking because you've assigned this issue to yourself. by the way i would love to get your help with those features. i'm swamped.

#2

salvis - September 13, 2008 - 19:01
Assigned to:salvis» Anonymous

It's already done. The two features are just two tiny code changes in the patch.

Sorry to confuse you...

#3

salvis - October 7, 2008 - 18:39

What does it take for you to commit that simple patch?

#4

litwol - October 7, 2008 - 19:25
Status:patch (code needs review)» fixed

time mostly.

http://drupal.org/cvs?commit=144936

#5

salvis - October 7, 2008 - 23:35

Thanks!

#6

Anonymous (not verified) - October 21, 2008 - 23:36
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.