Port to 6.x

dereine - September 13, 2008 - 23:12
Project:Tabs panel style
Version:5.x-1.x-dev
Component:Code
Category:feature request
Priority:minor
Assigned:Unassigned
Status:closed
Description

I think since Panels is "avaible" for drupal6

Here is a patch which just changes the info file for dr6
The Tabs are getting displayed

AttachmentSize
panels_tabs_port.patch329 bytes

#1

Wim Leers - September 14, 2008 - 11:33

True :)

Would you perhaps like to comaintain this module as well?

#2

dereine - September 14, 2008 - 13:33

Sure why not!

great!

is there a chance to get something like http://drupal.org/project/magic_tabs into the module?

#3

Wim Leers - September 14, 2008 - 21:21

That's definitely possible :)

#4

patchak - October 10, 2008 - 08:31

Hey there you two, nice to see you will work together on this module!! Any update on the magic tabs implementation???

Patchak

#5

dereine - October 10, 2008 - 23:34

Since http://drupal.org/node/295198#comment-1021663 we can send arguments into the magic_tabs callback

There we should get a certain pane as a tab, but i cannot figure out how to get only one pane of a certain panel

#6

dereine - December 17, 2008 - 18:13
Status:active» needs review

this patch does still applies

do you want to commit it?

could anyone else test?

#7

Wim Leers - December 22, 2008 - 19:50

dereine, I'm looking for a maintainer for this module. Would you be interested? I'm not comfortable committing a patch that ports a module if I don't plan to support it.

#8

dereine - December 22, 2008 - 21:00

mh why not,

i could do it,

i will try to find time on christmas to add the magic tabs addition

#9

Kripsy - December 23, 2008 - 01:18

Everything seems to work fine if you simply change the info. *Crosses fingers*

#10

dereine - December 23, 2008 - 09:46

thats logical, because panels is JUST ^^ a port to drupal6

so the api shouldn't change a lot

#11

ahkiam - January 3, 2009 - 04:12

subscribe

#12

mckeen_greg - January 11, 2009 - 13:49

Hi there,

I have the Panels2 Alpha3 for Drupal6 set up, with Panels Tabs and the patch above. The content displays, just not in tabs. It displays in the Panels "Default" view. I can select the display "Tabs" Option, in Layout Settings.

Just thought I'd let you know. I'd really like to have this module for 6, so thank you for your efforts.

#13

Flying Drupalist - January 12, 2009 - 16:48

Hi is the patch usable?

#14

Kripsy - January 13, 2009 - 01:55

Yes it works. I'm not sure what comment #12's problem is but I have the patched module and the latest panels and everything is fine except that tab settings no longer function. I believe this is due to a reworking of the tabs module layout though, the css properties are applied they just don't do anything.

#15

scott859 - January 25, 2009 - 04:46

subscribing

#16

Wim Leers - January 26, 2009 - 22:43

I don't have the time nor interest to maintain this module. So unless somebody steps up, I'm afraid I'll have to leave it in its current state for a long time. Sorry.

#17

kyeranr - February 11, 2009 - 16:32

subscribing

#18

EvanDonovan - April 7, 2009 - 18:39

Guess I'm a little late to the party. I didn't realize there was already a patch available. Anyway, attached is a patch that changes the .info and .module files (there were changes Deadwood found to the Form API).

Also, I have the patched files rolled up into a .tar.gz.

I'll consider whether I would be willing to maintain the module.

AttachmentSize
panels_tabs_d6.patch 1.94 KB
panels_tabs_6.x-1.x-dev.tar_.gz 8.98 KB

#19

degure - April 12, 2009 - 14:14
Priority:normal» minor

Thanks to EvanDonovan for sharing this!

#20

jdblank - April 16, 2009 - 17:55

Does the version in #18 work with Panels 3?

I installed it but I am not seeing the option in layout to use tabs.

#21

EvanDonovan - April 17, 2009 - 03:08

I'm not sure. I wouldn't be surprised if the plugin API has changed between Panels 2 and Panels 3. Try checking to see how one of the default panels style plugins is coded in Panels 3, and see if that's different than how it's coded in Panels 2.

#22

macrocosm - April 17, 2009 - 17:34

I'm going to try and get quicktabs in. Its so easy to style them for different uses.

#23

Flying Drupalist - April 17, 2009 - 18:22

Oh that would be terrific, thanks.

#24

patchak - April 17, 2009 - 20:32

+1 on quicktabs, especially with all those nice styles!!

Quicktabs has some issues with SEO tho, the way tabs panels handles url's is much better.

#25

macrocosm - April 19, 2009 - 07:37

Thats interesting .. didnt know that about seo.
Still you could easily use the quicktabs styles without using the module ... just borrow the css and the images and tweak to your liking.

#26

droople - May 3, 2009 - 19:51

Which release version of Panels does #18 support?

Thank you

#27

EvanDonovan - May 4, 2009 - 03:47

The version in #18 works for Panels 2. I don't know if it would work on Panels 3; I would suspect not. If anyone cares to test, that would be great.

#28

tommytom - May 13, 2009 - 21:56

please update project page

#29

EvanDonovan - May 13, 2009 - 19:51

@tommytom: I don't have commit privileges to this module, nor am I sure if I want to become the maintainer. If someone else wants to step up they can ask Wim Leers for the maintainer's role.

#30

dereine - May 13, 2009 - 20:36
Status:needs review» fixed

hei

i realized that Wim gave me rights to the module.

i created a initial dev release waiting for more testers(12hours) until next build of the dev version).

#31

EvanDonovan - May 13, 2009 - 20:59

Awesome - thanks, dereine! Is the dev version based on my code in #18?

#32

dereine - May 13, 2009 - 21:18

yes

see this cvs commit http://drupal.org/cvs?commit=211124

#33

tommytom - May 13, 2009 - 21:57

thanks

#34

patchak - May 14, 2009 - 21:02

I don't know if Panels 3 is stable enough, but i was wondering if anyone could look at integrating this module with panels 3, since it seems it's the new way to go...(regarding panels).

#35

dereine - May 14, 2009 - 21:10

i just published the drupal6.x version

i think it works both with panels 2.x and 6.x but i tested it with panels3.x

i think panels3 is currently the much much better version of panels

#36

EvanDonovan - May 14, 2009 - 21:22

It works with 3.x? Cool, I didn't realize that :)

I'm still on 2.x unfortunately, until I have time to figure out the upgrade path...

#37

tommytom - May 14, 2009 - 21:55

be aware that panels 3 still has a lot of bugs. I use it and cannot (for example) edit task handlers (UI bug)

#38

Daryljames - May 18, 2009 - 04:23

I'm getting this error on every page I try to implement this module on using panels 3 drupal 6
warning: array_shift() [function.array-shift]: The argument should be an array in /home/mysite/public_html/mysite.com/sites/all/modules/ctools/includes/context.inc on line 1015.

#39

Daryljames - May 24, 2009 - 04:17

nevermind i got it working... it was something else... sorry...

#40

dereine - May 24, 2009 - 08:44

thx for reporting!

#41

System Message - June 7, 2009 - 08:50
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.