Posted by robertDouglass on September 14, 2008 at 9:48am
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | tests |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
This patch adds tests that confirms the "type" field on the advanced search form. The trail is blazed for other advanced search form tests.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| advsearchform.patch | 3.25 KB | Ignored: Check issue status. | None | None |
Comments
#1
Just done the single test in this patch. Platform: XAMPP (Apache/2.2.4 (Win32) ; PHP/5.2.2 )
result is:
Also done complete search module tests, results:
#2
There's one typo, finsh, and testNodeType() isn't documented apart from inside the function.
I'm not sure why get_object_vars() is necessary here - why not $node->foo?
Also, status change to reflect adding coverage ;)
#3
@catch: fixed typo, added some documentation to testNodeType(). I updated get_object_vars to just stowing the node and accessing its components directly.
#4
Ok, that's the second time today Ctrl+s has failed me.
#5
Got a couple of syntax errors so re-rolled. Everything else looks fine, so marking this RTBC since there's no changes in the logic.
#6
Looked through. Code is well documented and easy to follow. There were some missing periods on the end of the single-line comments that I just couldn't let go, but fixed those and committed. Thanks! :)
#7
Automatically closed -- issue fixed for two weeks with no activity.