This patch adds tests that confirms the "type" field on the advanced search form. The trail is blazed for other advanced search form tests.

CommentFileSizeAuthor
#5 advanced-search-test.patch4.42 KBcatch
#4 advanced-search-test.patch3.35 KBrobertdouglass
#3 advanced-search-test.patch3.54 KBrobertdouglass
advsearchform.patch3.25 KBrobertdouglass

Comments

franskuipers’s picture

franskuipers commented

Just done the single test in this patch. Platform: XAMPP (Apache/2.2.4 (Win32) ; PHP/5.2.2 )

result is:
Search
28 passes, 0 fails, 0 exceptions
Advanced search form
Indexes content and tests the advanced search form.

Also done complete search module tests, results:
Search
175 passes, 0 fails, 0 exceptions
Advanced search form
Bike shed
Search engine queries
Search engine ranking

catch’s picture

catch
he/him
Primary language English
commented
Category: feature » bug
Priority: Normal » Critical
Status: Needs review » Needs work

There's one typo, finsh, and testNodeType() isn't documented apart from inside the function.

I'm not sure why get_object_vars() is necessary here - why not $node->foo?

Also, status change to reflect adding coverage ;)

robertdouglass’s picture

robertdouglass commented
Status: Needs work » Needs review
StatusFileSize
new advanced-search-test.patch3.54 KB

@catch: fixed typo, added some documentation to testNodeType(). I updated get_object_vars to just stowing the node and accessing its components directly.

robertdouglass’s picture

robertdouglass commented
StatusFileSize
new advanced-search-test.patch3.35 KB

Ok, that's the second time today Ctrl+s has failed me.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new advanced-search-test.patch4.42 KB

Got a couple of syntax errors so re-rolled. Everything else looks fine, so marking this RTBC since there's no changes in the logic.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Looked through. Code is well documented and easy to follow. There were some missing periods on the end of the single-line comments that I just couldn't let go, but fixed those and committed. Thanks! :)

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.