It would be very useful to see suport for the Taxonomy Browser module (http://drupal.org/project/taxonomy_browser) from PicLens.
The support could be similar to the existing "Piclens Taxonomy and Image support".

CommentFileSizeAuthor
#3 308241.patch3.33 KBdldege
#2 308241.patch4.07 KBdldege

Comments

dldege’s picture

Assigned: Unassigned » dldege

There are some problems with the way the matching nodes are being selected. I'm working on a patch for this that will use the core taxonomy_select_nodes() API call. This way single term, or, and are all supported. Ultimately I think it would be better if a module was written that just added the media:rss tags in for image nodes during the "rss item" stage of core taxonomy feed generation. I'll have a patch for this current implementation soon.

dldege’s picture

Assigned: dldege » Unassigned
StatusFileSize
new4.07 KB

Here is the patch - sorry it took so long I got busy elsewhere.

It uses the taxonomy module api so it supports and/or term ids - for example as produced by the taxonomy category browser in the rss feed url.

dldege’s picture

StatusFileSize
new3.33 KB

Better patch w/o my commented code snippet at the top :)

swentel’s picture

@dldege
Are you by any chance interested in taking co-maintainership for this module ? I could use some help as I'm having less and less time to get important stuff done for this module. If you're interested, you are even free to take full ownership of the project.

dldege’s picture

@swentel

I'd be happy to help as I can and keep an eye on the issue queue - I see right now a couple of the issues are ones I submitted :) I too feel to busy to take it over completely but I'm willing to help if you want to give me cvs commit rights.

Thanks

swentel’s picture

Ok, great, I gave you access, all my commits are in, so you are free to go nuts :)

dldege’s picture

Status: Active » Needs review
swentel’s picture

Status: Needs review » Reviewed & tested by the community

Patch applies fine and no functionality is lost, so rtbc

dldege’s picture

Status: Reviewed & tested by the community » Fixed

Fixed in piclens_taxonom_image.module version 1.1.2.7

@swentel - port to D6 branch?

swentel’s picture

This one fails completely on D6 branch, I have a bit of time on friday to look at it, but if you have one allready, feel free to commit it.

dldege’s picture

I don't have a D6 test environment yet either so I'll defer D6 migration to you for now.

swentel’s picture

Version: 5.x-1.6 » 6.x-1.x-dev
Status: Fixed » Active

changing version, so I don't forget

swentel’s picture

Status: Active » Fixed

commited to D6 branch, thanks!

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.