Another part of #250047: Rework the SimpleTest results interface and clean-up of backend code that can be broken out.

CommentFileSizeAuthor
#5 simpletest.js-cleanup.patch3.17 KBfloretan
#2 308262-simpletest-js-cleanup.patch3.31 KBdamien tournoud
simpletest.js-cleanup.patch3.31 KBfloretan

Comments

floretan’s picture

floretan commented
Title: simpletest.js cleanup » clean-up and documentation of simpletest.js
damien tournoud’s picture

damien tournoud commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 308262-simpletest-js-cleanup.patch3.31 KB

Removed a small functional addition. The cleanups looks good.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Why do we have stuff added after / No newline at end of file?

damien tournoud’s picture

damien tournoud commented

@catch: I just added the newline at the end of the file.

floretan’s picture

floretan commented
Status: Needs review » Needs work
StatusFileSize
new simpletest.js-cleanup.patch3.17 KB

@damien: thanks for pointing out the functional change.

Somehow the revised patch didn't apply cleanly though. This one should work.

floretan’s picture

floretan commented
Status: Needs work » Reviewed & tested by the community

oops

damien tournoud’s picture

damien tournoud commented

@flobruit: the only difference I can see is the header:

Mine:

- // $Id: simpletest.js,v 1.2 2008-04-23 18:50:49 dries Exp $

Yours:

+ // $Id: simpletest.js,v 1.2 2008/04/23 18:50:49 dries Exp $

Strange :)

floretan’s picture

floretan commented

My eclipse has been doing some weird things with patch validity due to a stale internal cache, that might have caused this strange problem.

Anyway, patches from #2 and #5 should both work.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Awesome. Committed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.