Posted by chx on September 15, 2008 at 5:20am
Jump to:
| Project: | Drupal core |
| Version: | 6.x-dev |
| Component: | base system |
| Category: | bug report |
| Priority: | critical |
| Assigned: | chx |
| Status: | closed (fixed) |
Issue Summary
The current tests are enough to show this you just need to rewrite module_implements :D actions_synchronize badly needs this TRUE. 6.x too. Simply, when you resync you need to reset as well.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| resync_reset.patch | 513 bytes | Ignored: Check issue status. | None | None |
Comments
#1
Tested and works fine.
Looking around the actions_synchronize code, I'm not sure even why it needs the $actions_in_code parameter. The only time it isn't given actions_list() for that is when it is called from system_modules_submit. I'll file a separate issue for it, but just wanted to know what you think chx.
#2
See #306540: Orphaned assigned actions still triggered and cannot be removed for proposed change to actions_synchronize.
#3
There is one thing for sure, #298600: DBTNG: make module_implements work regardless of bootstrap phase is horribly broken without this.
#4
Sorry about getting off track. I agree with chx that this is needed and the patch is good and tested fine. RTBC
#5
Committed. Thanks!
#6
Automatically closed -- issue fixed for two weeks with no activity.
#7
Need to get into 6.x too.
#8
Committed to Drupal 6.x, thanks.
#9
Automatically closed -- issue fixed for two weeks with no activity.