Inspired by #308521: DBTNG is full of stray whitespace, did a search for [ \t]+$ in core and found a lot of them.

CommentFileSizeAuthor
#1 spaces.patch70.29 KBdave reid
spaces.patch73.26 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Title: Stray whitespace throughout core » Coding standards - core whitespace
StatusFileSize
new spaces.patch70.29 KB

Re-rolled. Anyone able to help review? It's easy...

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Status: Needs review » Reviewed & tested by the community

no functional changes in the patch. it removes the trailing spaces, nothing more..

notes:
make smaller patches (by module)
next issue: remove tabs

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I'll be sure to do that for future reference. Thanks Pasqualle!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Actually, for this type of thing that's extremely minor, one patch that does the exact same thing across all of core is a lot easier to review and commit.

Just running the test suite to make sure nothing breaks.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Ok, looks good.

Committed. Thanks!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.