Yesterday, I found a broken URL in the Drupal source, so wrote a script (attached) to investigate how widespread this issue is. It turns out the one I found is the only real incidence, hahahaha.
grep -RnI http:// * | php -f test.php
Anyway, the broken link is includes/theme.inc:11 - http://drupal.org/node/253 which used to point to the Drupal Handbook. Perhaps http://drupal.org/theme-guide is a better link anyway?
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | theme.inc-d6link.patch | 405 bytes | lyricnz |
| #2 | theme.inc-d5link.patch | 414 bytes | lyricnz |
| #2 | theme.inc-d6link.patch | 405 bytes | lyricnz |
| #1 | 308549.theme_link.patch | 587 bytes | dave reid |
Comments
Comment #1
dave reidGood catch! Patch applies for 7.x, 6.x and 5.x. Ready for review.
Comment #2
lyricnz commentedThanks for the patch, but the link actually refers to a Drupal 6 theming page. Maybe we should also change the link-text? Attached patch for D6 changes to Theme guide
The Drupal 5 (and earlier) link is http://drupal.org/node/509 - see attached patch, which changes the link to Theme developer's guide
I thought "could putting something as version-brittle as this in theme.inc be a bad idea?", but figure it only changes with major versions, so is not that big a deal.
Comment #3
dave reidI'd probably change the 6.x version of the link to the node/X version since I'm guessing it'll be renamed to theme-guide/6 eventually.
Comment #4
lyricnz commentedSure thing. Attached.
Comment #5
dave reid6.x patch from #4 and 5.x patch from #2 applied, tested and good to go.
Comment #6
dries commentedI've committed the patch from #4 to CVS HEAD and DRUPAL-6. Thanks!
Comment #7
lyricnz commentedMark issue as fixed when patch from #2 is applied to D5.
Comment #8
pasqualleComment #9
drummCommitted to 5.x.
Comment #10
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.