I'm developing a Drupal 6 site which requires conversion of video files to flv. This module seems like the only reasonable way to go. There is a D6 version of Flash Video, but that module makes too many assumptions about how I want to set things up, IMO. It has a FFmpeg conversion function that I could use, but I'd rather do it the Right Way and try and port FFmpeg Wrapper instead. I imagine it won't be too hard.

Media Mover would be nice to use, but it seems pretty far from a D6 port, so I think I'll just implement my own thin conversion module on top of FFmpeg.

@arthurf: Is anyone already working on a port? Would you be willing to review such a patch? Are you doing a lot of development on the D5 branch or is the code reasonably frozen?

CommentFileSizeAuthor
#7 ffmpeg_wrapper-308630-d6_addition.patch997 byteszoo33
#5 ffmpeg_wrapper-d6.patch4.08 KBzoo33
#1 ffmpeg_wrapper-d6.patch3.57 KBzoo33

Comments

zoo33’s picture

zoo33 commented
Status: Active » Needs review
StatusFileSize
new ffmpeg_wrapper-d6.patch3.57 KB

This patch contains the few changes that are needed in order to run FFmpeg Wrapper in Drupal 6. However I think the following patch is also very important, both for D5 and D6:

#308927: Fixing PHP warnings

Also, please concider:

#308760: Coding standard cleanup

zoo33’s picture

zoo33 commented
Status: Needs review » Needs work

Update: Another piece of code needs to be changed, around line 640. cache_get() now returns an unserialized value automatically.

Before:

<?php
	$cache = cache_get('ffmpeg_wrapper_default_output', 'cache');
	if (empty($cache->data)) {
	  return unserialize($cache->data);
	}
?>

After:

<?php
	$cache = cache_get('ffmpeg_wrapper_default_output');
	if (is_array($cache->data)) {
	  return $cache->data;
	}
?>
arthurf’s picture

arthurf commented

I'll branch D5, which has the patches you've done and then we can build D6 of that- can you create a unified patch for D5 in its current state?

arthurf’s picture

arthurf commented

Ok, I've created a D6 branch from the current D5 code.

zoo33’s picture

zoo33 commented
Status: Needs work » Needs review
StatusFileSize
new ffmpeg_wrapper-d6.patch4.08 KB

Great! Here's a new patch against the current DRUPAL-5. Tested briefly.

arthurf’s picture

arthurf commented
Status: Needs review » Closed (fixed)

Committed to the D6--1 branch

zoo33’s picture

zoo33 commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new ffmpeg_wrapper-308630-d6_addition.patch997 bytes

I seem to have missed a FAPI change in the port. Another patch!

Babalu’s picture

Babalu commented

patching file ffmpeg_wrapper.module
patch unexpectedly ends in middle of line
Hunk #1 succeeded at 123 with fuzz 1.

against 6.x dev

zoo33’s picture

zoo33 commented
Status: Needs review » Fixed

Er... I'm not sure what happened, but that change was already committed. I must have worked on the wrong copy or something.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.