Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
node system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
15 Sep 2008 at 17:11 UTC
Updated:
2 Jan 2014 at 23:45 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dwwI think that's an improvement. I'd move this directly to RTBC, but I haven't actually tried applying it.
Comment #3
lilou commentedSee: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476
Comment #4
catchLooks like a good change to me as well.
Comment #5
todd nienkerk commentedPrompting the user to "provide" an explanation is an excellent idea. Much clearer!
I suggest removing "to this content" from #description. Within the context of adding or creating a node, I think it's perfectly clear without it -- and it's always good to keep things as concise as possible!
Comment #6
catchRe-rolled with Todd's changes. Makes plenty of sense to remove 'to this content' here.
Comment #7
keith.smith commentedThese still seem a bit clumsy. We could do:
That's better, but it's less than ideal because people are only going to read the first few words and the operative part is now after the clause.
Is the "motivations" part really necessary? If the idea is for a user to explain their changes, why do we care why they do it? If its not necessary, then why not something as simple as:
Or, if that seems abrupt, then "Please provide an explanation for your changes."
Comment #8
todd nienkerk commentedkeith.smith: From an efficiency standpoint, it's usually better to tell the user what a thing is before explaining why they should use it.
When someone is quickly scanning a page, they will want to know "what" before "why," as in: "What is this? And why would I want to do that?" Providing "what" before "why" also has the advantage of quickly reminding users of its purpose if they've previously encountered it.
Comment #9
keith.smith commented@Todd Nienkerk: OK. I generally agree with #8. I'm not sure what you're suggesting, though. Can you provide a concrete suggestion deriving from either catch's patch in #6 or my suggestions in #7?
Comment #10
dries commentedI like the patch in #6 so I've committed that. Thanks!
Comment #11
todd nienkerk commentedkeith.smith: I liked catch's changes in #6. Sorry I wasn't clear on that.