A translator posted this request at http://www.ubercart.org/issue/6496/different_meaning_word_order.

We're using "Order" to refer to both a customer's order and the sort order of some items in Ubercart. It would be helpful if we used separate terms so translations don't look confused. : )

CommentFileSizeAuthor
#7 uc.order_wording.patch12.49 KBcha0s
#2 uc.rename_order.patch3.77 KBcha0s

Comments

cha0s’s picture

Assigned: Unassigned » cha0s
cha0s’s picture

Status: Active » Needs review
StatusFileSize
new3.77 KB

I created a patch for these cases I could find. I used a regex to find them so there might be more, but I think I found all of them. The regex I used was:

t\('.*order.*'\)

cha0s’s picture

*bump*

rszrama’s picture

Issue tags: +i18n
Island Usurper’s picture

When I applied this patch, the first place I looked was the product edit form. I had forgotten that spot wasn't even in the patch because the label for the sort order is "List position". Personally, I think "Sort by" is grammatically awkward ("The product's sort by is 4.") so I propose using "List position" everywhere else.

I won't be stubborn about this if no one else thinks that's a good idea, though.

rszrama’s picture

hehe I actually thought of that after reviewing this patch, even though I initially created this issue. I prefer either "List position" or possible "Sort order" if that makes sense.

cha0s’s picture

StatusFileSize
new12.49 KB
Island Usurper’s picture

Status: Needs review » Needs work

The change in theme_uc_attribute_options_form() takes out the last column.

Looks good otherwise.

cha0s’s picture

Could you be more specific?

Island Usurper’s picture

Title: Use "Sort by" or "Order by" instead of "Order" » Use "List position" instead of "Order"
Status: Needs work » Fixed

Bah, word-wrapping in my browser hid it from me. Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.