Not Compatible with CCK 6.x-2.1

Flying Drupalist - September 16, 2008 - 20:23
Project:Comment CCK
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

I can't find this checkbox. I'm looking in the fields options and, etc and I don't see it anywhere.

#1

arhak - September 17, 2008 - 01:14

+1
subscribing

#2

drupaloSa - September 20, 2008 - 22:28

subscribing

#3

txcrew - September 21, 2008 - 03:45
Title:Allow Comments to alter this field - where?» Not Compatible with CCK 6.x 2.0rc7
Category:support request» bug report
Priority:normal» critical

This seems to be an affect from CCK 6.x 2.0rc7 (http://drupal.org/node/306274). Not quite sure where it went wrong given the list of changes/fixes. My guess would be here:

The admin forms (field creation, field edition...) have been renamed to comply with usual form
naming conventions. Modules and custom code that rely on those form ids through hook_form_alter() or
drupal_execute() will need to be updated.

Since I really have no background in programming, maybe someone else can give a nudge. Perhaps for an immediate solution, rollback to CCK 6.x 2.0rc6 (http://drupal.org/node/295736).

#4

chasz - September 21, 2008 - 04:08

+1

#5

txcrew - September 21, 2008 - 04:17

After further investigation I believe to have tracked down the line to change. Please forgive my lack of programming knowledge.

I changed line #58 from

  if ($form_id == '_content_admin_field') {

to

  if ($form_id == 'content_field_edit_form') {

Hope this is a step in the right direction.

txcrew

#6

drupaloSa - September 21, 2008 - 11:24

@txcrew: does this work for you? I couldn't find where the module settings are.

#7

txcrew - September 21, 2008 - 14:05

@drupaloSa

Note: I am using 6.x version of comment CCK.

Yes, this does work for me.

I had to make the changes in #5 in comment_cck.module in order to see the checkbox on the field settings page (admin/content/node-type/MY_CONTENT_TYPE/fields/MY_FIELD_NAME

#8

drupaloSa - September 21, 2008 - 14:14
Status:active» reviewed & tested by the community

Sorry, i forget an extra underscore in the code. Suggested change in #5 works for CCK 6.x 2.0rc7.

#9

agentrickard - September 26, 2008 - 19:10

Confirmed

#10

RoboPhred - September 29, 2008 - 15:15

Works for me, thanks!

#11

sumitk - October 1, 2008 - 11:15

working with #5 on line 58 in module
thanks :)

cheers!!
sumitk

#12

sanduhrs - January 4, 2009 - 11:08

Patch attached based on #5

AttachmentSize
comment_cck_309367_01.patch 641 bytes

#13

sanduhrs - January 4, 2009 - 11:13
Title:Not Compatible with CCK 6.x 2.0rc7» Not Compatible with CCK 6.x-2.1
Priority:critical» normal

Changing title and prio.

#14

Flying Drupalist - January 4, 2009 - 17:55

Well, looks good. Please commit.

#15

ultimateboy - January 19, 2009 - 20:49
Priority:normal» critical

Tested and confirmed patch in #12.

Changing priority to critical.. as this module is unusable without this modification.

#16

criz - January 26, 2009 - 03:02

patch in #12 works for me too...

#17

manimejia - March 15, 2009 - 21:59

had same problem.
implemented change in comment #5.
Works now.

M.M.

#18

criz - March 30, 2009 - 23:38

wonder if this could go in a new release? plan to use this module in an installation profile and thus a working module out of the box would be nice...

#19

joshuajabbour - March 31, 2009 - 00:51

This patch conflicts with #295478: Double appearance of checkbox "Allow comments to alter this field". I've attached a new version to that issue, so the patch in #12 should be applied first.

But yes, rolling this into a new release would rock, as this module currently is unusable without it.

#20

joshuajabbour - April 1, 2009 - 01:29

I've written a new, unified patch that fixes this issue along with a few others. It's listed under #420092: Bring comment_cck up-to-date, combine patches and can (should) be applied in place of the patch above.

#21

opensanta - May 8, 2009 - 20:08
Status:reviewed & tested by the community» fixed

Committed. Thanks!

#22

System Message - May 22, 2009 - 20:10
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.