Hi...I'm not a coder by any means, but as a front end developer I think it would be more clear to move the post time after the linked message. Example:

The current structure: Joe is watching a movie a moment ago

The preferred structure: Joe is watching a movie - a moment ago

Change line 183
$block_content .= htmlspecialchars($sm['status_fb'], ENT_NOQUOTES) ." <span class='". t("submitted") ."'>". $time . t(' ago') ."</span>";

to this
$block_content .= htmlspecialchars($sm['status_fb'], ENT_NOQUOTES);

Add below line 209
$block_content .= '</a>';

the following on line 210
$block_content .= '<span class="submitted"> - '. $time .' ago</span>';

Any thoughts on this?

Kind regards,

Marius

Comments

icecreamyou’s picture

icecreamyou commented
Assigned: Unassigned » icecreamyou
Priority: Normal » Minor

First of all, adding a dash to that sentence doesn't make grammatical sense. And a dash is a relatively arbitrary character; pipes and parentheses could also be used. Further, the way I've done it is the way core does it. And last, the time is wrapped in a span so that it can by styled differently should you so wish. On my sites, that class is light grey and half the font size of the normal status text.

That said, I can see where you're coming from. While I don't think this is important enough to add a setting for, I'll wrap the whole string in t() so it can be translated to show however you wish. This change will appear in the next -dev version, but I won't release it until more important changes have gone in so everyone that uses this module won't have to upgrade. In the mean time, you can just go ahead and change the code manually if you wish.

icecreamyou’s picture

icecreamyou commented

Oh... I missed the part about not having the time be linked. I'll look into that - although it won't matter for functionality since it's the entire div that controls the sliding.

icecreamyou’s picture

icecreamyou commented
Status: Active » Fixed

Fixed, I think, locally. Will be in CVS soon.

mariusooms’s picture

mariusooms commented

First of all, adding a dash to that sentence doesn't make grammatical sense. And a dash is a relatively arbitrary character; pipes and parentheses could also be used. Further, the way I've done it is the way core does it.

I thought a dash can actually be used as a means to pause, but English is my 2nd language. You could also use a full stop, this is what Facebook does. Also isn't this module called Facebook-style_Status and not Drupal-style_Statuses, so you wouldn't have to follow core, but mimic Facebook ;) (no pun intended)

I missed the part about not having the time be linked. I'll look into that - although it won't matter for functionality since it's the entire div that controls the sliding.

Yes, this is actually the reason why I added a dash, which could also be any other type of punctuation, since you can NOT remove the underline text-decoration from the span element.

I won't release it until more important changes have gone in

Understandably so, no rush! It was something I considered aesthetically better (to have only the message underlined and not the timecode), but obviously this is STRICTLY personal. Thanks for considering and working on this...

Regards,

Marius

icecreamyou’s picture

icecreamyou commented

Sure, no problem. The closing 'a' tag has been moved before the time in this morning's -dev release, so you should be all set there. Let me know if you find any problems.

I thought a dash can actually be used as a means to pause, but English is my 2nd language. You could also use a full stop, this is what Facebook does.

Technically a dash does mean a pause in English; but the sentence "IceCreamYou is happy - a moment ago" makes no sense for two reasons. The first is verb tense - "is" (present tense) shouldn't be used with "ago" (past tense) - but we can't really avoid that. The second, more relevant reason is that "a moment ago" is a descriptive modifier (adverb phrase) which shouldn't be separated from the verb in most cases. A dash or comma would be inappropriate because both would designate the time as a separate part of the same sentence, which it is not. A full stop is acceptable but because the time is not a sentence by itself I would expect it to be in parentheses. And honestly parentheses - with or without a period - might be the best way to go here, because they offset the time in a parenthetical (non-intrusive, grammatically correct) manner. Using a pipe would have a similar effect.

I prefer not to use any punctuation though, simply because I view the time as a continuation of the sentence, and also the time is smaller and a different color in my theme (because it's set to class="submitted" IIRC).

Either way, everything's wrapped in t() now, so you can do it however you like. :) Sorry for the grammatical discourse.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.