Plus1 vote retrieval should be more explicit

eaton - September 16, 2008 - 20:31
Project:Plus 1
Version:6.x-2.2
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Plus1 votes are correctly cast as 'points', but when the values are retrieved for display, it pulls in all votes regardless of type. If fivestar or other voting modules are installed at the same time, it makes collisions easy to trigger. The attached patch specifies 'points' and specifies the results of the 'sum' function when retrieving the current score, to avoid any confusion.

Great module!

AttachmentSize
plus1.patch880 bytes

#1

Chill35 - September 16, 2008 - 23:53

Thanks Eaton!

#2

Chill35 - September 18, 2008 - 06:39
Status:needs review» fixed

Patch has been reviewed, tested and committed. The next version contains it. Thanks again.

#3

Anonymous (not verified) - October 2, 2008 - 06:42
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.