Allow FAQ to adhere to Access Modules.

Perhaps this needs to be worked in using something like

if (module_exists('node_access')) {
.....

So that it can work both ways.
The facility to regulate who gets what without the node_access module should be retained IMHO.

no, that's not an option, as that breaks drupal's modular setup... also, what about the following modules, Taxonomy Access Control, Taxonomy Access Control Lite, Content Access or even future modules? do they also need a special case?

I was positing a solution to your particular problem and pointing out that it breaks the existing ability to control who sees what. The patch may work for you but I for one won't be using it for that reason. YMMV

mrmelson: the unpublished node issue has already been reported and fixed in #277349: Unpublished FAQ node visible to everyone.

I will investigate the nodeaccess problem shortly. I'm not particularly fond of either of the two solutions posted above, but will look into it further.

Cheers,
Stella

my solution, is based upon looking to how other modules handle their stuff ;)

Perhaps a solution might be a configuration checkbox that says "Skip FAQ Access Checking" with a note that says it is to be checked whenever access control is controlled by another module.

in my opinion, that i not an option, as that will lead to usability problems, and is exactly the opposite as what is "encouraged" by drupal.

Removing the view clause, will make the faq content-type behave exactly the same as all other content types, which sould be expected.

Actually, you probably just need to change the op=view code:

  else if ($op == 'view' && user_access('view faq')) {
    return TRUE;
  }

There are not many cases, other than op=create, where hook_access should be returning FALSE. I'm pretty sure you have all the appropriate db_rewrite_sql's.

Nancy, that doesn't work when you need access control based of for example the category (taxanomy) the faq is in.

remember, we shoudn't decide who's allowed to view the faq, the access modules should. (that's why they're there in the first place)

Attached is a patch which should resolve the issue. The 'view faq' permission is now gone and has been replaced with 'view faq page' which controls which users have access to view the generated faq pages, and that's all. If site admins wish to control which users have access to faq nodes, or individual faqs, then one of the access modules should be used, e.g. nodeaccess, tac_lite, etc.

Cheers,
Stella

contains duplicate code, for example:

node_access() already specifies:

  // Let authors view their own nodes.
  if ($op == 'view' && $user->uid == $node->uid && $user->uid != 0) {
    return TRUE;
  }

also disallowing access on unpublished status is already covered for in node_access(), by the final return FALSE, this might also give problems with content moderation modules.

patches are looking visually okay, however, i would like to see another review ;)

Committed.

Released in 5.x-2.12 and 6.x-1.8.