adminrole was not assigning permissions when I would add new modules as it should. I had the role setup and everything. The attached patch will fix it. Basically, it appears that the module_list() function was not refreshing. The attached patch will fix this.

CommentFileSizeAuthor
adminrole_checkall.diff364 bytesdesignerbrent

Comments

Babalu’s picture

Babalu commented

can you make a .patch file from this
i can not patch with this file on my vps root

designerbrent’s picture

designerbrent commented

Babalu: This is a patch file. If you so desire, you can rename it to .patch. Or you can open it and make the small change manually.

http://drupal.org/patch/apply

Babalu’s picture

Babalu commented

rename and works. thx :)

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented
Status: Needs review » Reviewed & tested by the community

This patch works great... I applied a few weeks ago and have been checking periodically to make sure all permissions are applied - have tested many modules and no issues yet. Is it too bold to say it's 'reviewed & tested by the community'? ;)

femrich’s picture

femrich commented

I'm experiencing the same problem, and the warnings on the drupal.org instructions for patching make me very hesitant to apply the patch (hesitant to apply any patch, actually). Any idea when this patch will be added either to .dev or beta for 6.x?

mariuss’s picture

mariuss commented

@femrich, I understand your concerns, but this is a really trivial patch, just look at it and make the change manually. Basically, the first argument to module_list needs to be changed from FALSE to TRUE. It is much safer to apply the patch than to use the dev version, since the dev version most likely has other changes as well.

moshe weitzman’s picture

moshe weitzman commented

Would be great to get this in and roll a new release. The current release does not have the fix for #297920: Wrong role gets admin access. thanks.

femrich’s picture

femrich commented

Sorry, but I am a coding newbie. I'll look into this, but it will take me a while just to figure out what the instructions in your reply mean, mariuss. My bad, of course. But thanks for the feedback and I will try to figure out how to apply this patch...

Leeteq’s picture

Leeteq commented

Subscribing.

Bevan’s picture

Bevan commented

It'd be really good to get this committed and released. I think JacobSingh (maintainer) is swamped with larger things with his new job at Acquia right now. I have pinged him.

Bevan’s picture

Bevan commented

Committed, will be released as RC2

Bevan’s picture

Bevan commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.