Little bit of optimization
sudhaker - September 17, 2008 - 00:15
| Project: | Profile Privacy |
| Version: | 6.x-1.2 |
| Component: | Code |
| Category: | feature request |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | active |
Description
I guess INSERT is redundant when $privacy is 0 ; so why bother...
Existing code:
function profile_privacy_set_field_privacy($field_name, $privacy = 0) {
profile_privacy_get_fields(NULL, TRUE);
$field = profile_privacy_get_field($field_name);
db_query('DELETE FROM {profile_privacy_fields} WHERE fid = %d', $field->fid);
db_query('INSERT INTO {profile_privacy_fields} (fid, privacy) VALUES (%d, %d)', $field->fid, $privacy);
}Suggestion: change in last statement
function profile_privacy_set_field_privacy($field_name, $privacy = 0) {
profile_privacy_get_fields(NULL, TRUE);
$field = profile_privacy_get_field($field_name);
db_query('DELETE FROM {profile_privacy_fields} WHERE fid = %d', $field->fid);
if ($privacy > 0) db_query('INSERT INTO {profile_privacy_fields} (fid, privacy) VALUES (%d, %d)', $field->fid, $privacy);
}Cheers,
Sudhaker