CivicActions is reviewing and upgrading multiple modules for use on client sites. Part of this work is a coding standards review. Attached you will find a patch based on a review with the coder module and a careful examination of the code. Thanks!

CommentFileSizeAuthor
#2 simplemenu_2.patch822 byteswmostrey
simplemenu.patch1.19 KBwmostrey

Comments

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Needs work

Patch no longer applies, the 'description' has been fixed already, select options still look like they could use t().

wmostrey’s picture

wmostrey commented
Status: Needs work » Needs review
StatusFileSize
new simplemenu_2.patch822 bytes

Here's a re-roll of the patch.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

This one applies cleanly and the changes still look good. So marking RTBC.

zroger’s picture

zroger commented
Status: Reviewed & tested by the community » Fixed

committed

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.