Posted by joshuajabbour on September 17, 2008 at 9:04pm
2 followers
Jump to:
| Project: | Nodequeue |
| Version: | 7.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Problem: Smartqueue_taxonomy could accidentally update or delete the wrong subqueues when terms are updated or deleted. This might happen because the current SQL just searches for subqueues with a reference that equals the term ID. However, regular nodequeue subqueues store the queue id as the subqueue reference (and other smartqueue modules could store any arbitrary data as the reference). I marked this bug as critical due to the potential for data loss.
Solution: Make sure only smartqueue_taxonomy subqueues are deleted. Add WHERE owner = 'smartqueue_taxonomy' to queries.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| smartqueue-ownercheck.patch | 1.62 KB | Ignored: Check issue status. | None | None |
Comments
#1
This looks good to me. I will review in more detail as soon as possible. Thanks for catching this!
#2
Committed to Drupal 6 and 5 branches.
Thanks again!
#3
Automatically closed -- issue fixed for two weeks with no activity.