Problem: Smartqueue_taxonomy could accidentally update or delete the wrong subqueues when terms are updated or deleted. This might happen because the current SQL just searches for subqueues with a reference that equals the term ID. However, regular nodequeue subqueues store the queue id as the subqueue reference (and other smartqueue modules could store any arbitrary data as the reference). I marked this bug as critical due to the potential for data loss.
Solution: Make sure only smartqueue_taxonomy subqueues are deleted. Add WHERE owner = 'smartqueue_taxonomy' to queries.
| Comment | File | Size | Author |
|---|---|---|---|
| smartqueue-ownercheck.patch | 1.62 KB | joshuajabbour |
Comments
Comment #1
ezra-g commentedThis looks good to me. I will review in more detail as soon as possible. Thanks for catching this!
Comment #2
ezra-g commentedCommitted to Drupal 6 and 5 branches.
Thanks again!
Comment #3
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.