got this message when i upgraded not quite sure on how to fix it as I havent got round to learning php properly yet, any suggestions on how to fix it would be greatly appreciated

warning: Missing argument 3 for drupalforfirebug_views_pre_view(), called in /home/animatio/public_html/modules/views/views.module on line 598 and defined in /home/animatio/public_html/modules/drupalforfirebug/drupalforfirebug.module on line 31.

When i go to the views module the following code is

// Call a hook that'll let modules modify the view just before it is displayed.
foreach (module_implements('views_pre_view') as $module) {
$function = $module .'_views_pre_view';
$output .= $function($view, $items); (line 598)
}

also when i go to the drupal for firebug line 31

* Implementation of hook_views_post_view();
*/
function drupalforfirebug_views_pre_view(&$view, &$display_id, &$args) { (line 31)
global $dfp_runtime;
$data = drupalforfirebug_array_compare((array) $dfp_runtime['drupalforfirebug_views']['original'][$view->name], (array) $view);
$output = theme('drupalforfirebug_field_object', 'view', $view->name, NULL, $data);
drupalforfirebug_log($output, 'hook_views');
}

CommentFileSizeAuthor
#6 drupalforfirebug-309932.patch902 bytesfp

Comments

josuealcalde’s picture

It is a bug I think.
It can be solved changing line 31 in drupalforfirebug.module:

function drupalforfirebug_views_pre_view(&$view, &$display_id, &$args = array()) {

(making the last argument optional)

janwari’s picture

Changing line 31 to allow optional argument by adding &$args = array() didn't work for me.
In firebug I still get "No Drupal for Firebug data was found. Either this site is not running Drupal or the Drupal for Firebug module has not been installed/enabled."

halo1982’s picture

I am having the same issue. Changing line 31 got rid of the error, but I still get "No Drupal for Firebug data was found. Either this site is not running Drupal or the Drupal for Firebug module has not been installed/enabled."

mason@thecodingdesigner.com’s picture

Changing line 31 fixed the issue for me. Thanks for the tip.

davea’s picture

Ditto on line 31- error is gone.

DaveA

fp’s picture

Status: Active » Reviewed & tested by the community
StatusFileSize
new902 bytes

Patch per #1.

fp’s picture

Status: Reviewed & tested by the community » Needs review

sorry - wrong status... I guess this one is more appropriate.

joshk’s picture

Status: Needs review » Closed (fixed)

committed to 5.x and 6.x branch.