I installed this module and I have found a bug.

I login as a non-admin and go to: My account->Signups->Available .

Here is where event nodes are displayed that the current user can signup for. The problem is that outdated/old and non-published events/node show up.

I spent some time reviewing the signup module and cannot find where the the list of events/nodes is generated. I was hoping to edit a SELECT statement somewhere so I could add conditions...I can't find where this list is generated.

Comments

dww’s picture

dww
we/he/they
commented
Component: Code » Views integration
Assigned: Unassigned » dww
Status: Active » Fixed

It's a view. See signup_views.inc. Better yet, see admin/build/views on your site.

"Outdated/old" signups is by design. Signup doesn't know if your signup-enabled nodes have dates at all. If you want these views to filter based on a CCK date field or from the event module's date "field", you need to add that filter appropriately on your site. See step #7 in the INSTALL.txt file shipped with the module.

"Unpublished" is a bug. I just fixed the default views shipped with signup to include a filter for that by default. This will go out in version 5.x-2.5. See http://drupal.org/cvs?commit=140873 for details.

Thanks for the report,
-Derek

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

johnhanley’s picture

johnhanley commented

I have a client using 5.x.2.7 who wanted to exclude past events from the signup admin list page (admin/content/signup).

I don't ordinarily like modifying third-party modules for obvious reasons, but since the 5.x branch is feature frozen I modified the signup_admin_form_sql() function to exclude unpublished nodes. Here's how:

1) Add a where clause to $admin_common_sql array:

    'where' => array(
      'n.status = 1',
    ),

2) Add an INNER JOIN to $sql_count string:

  $sql_count = "SELECT COUNT(s.nid) FROM {signup} s INNER JOIN {node} n ON n.nid = s.nid";

Now if only there was an easy way to make the Start column sortable...

dww’s picture

dww
we/he/they
commented

@Bacteria Man: 5.x* is still accepting bug fixes. If admin/content/signup is showing unpublished nodes (which it appears to be doing), that's a bug, and I'd still be willing to fix it. However, that's separate from this issue, which was about the "available signups" listing. So, please open a new issue, and ideally attach a patch. Thanks!