Add back SET NAMES="utf8"

This is blocking #279851: Replace LOWER() with db_select() and LIKE() where possible

Trivial patch, I can't reproduce the specific bug that Damz got in the other issue, but it applies fine, breaks nothing, and my non-utf-8 aware shell noticed a difference, so marking rtbc.

This really is critical ;)

Tested this regression test with and without the we-love-utf8-names patch and it detects the bug successfully.

This patch just rolls them into one, please don't credit on commit.

db_fetch_object() is deprecated, so the regression test is wrong. :-( It should instead be:

$from_database = db_query("SELECT name FROM {test} WHERE name = :name", array(':name' => $name))->fetchField();
$this->assertIdentical($name, $from_database, t("The database handles UTF-8 characters cleanly."));

Also, let's put a comment on the query to say why we're doing it.

CNW, but I agree on critical.

Like this?

Yep. I'd prefer a comment on the line in the driver, but I leave that to the committers to decide. (Haven't tested yet, just visual review.)

Attached patch cleans up the Insert query in the unit test to use the new builder and adds comments to both of the MySQL config lines (this and the strict mode line). Test passes. Setting RTBC to get it into webchick's queue even though I am posting the patch, since this is a blocker. :-)

Committed to CVS HEAD. Thanks! And 'yay' for the tests ...

Shouldn't we use mysql(i)_set_charset('utf8') ?