Download & Extend
Light Fantastic » Issues

Backport to Drupal 5.x

Posted by Bevan on September 19, 2008 at 2:59am
Project:Light Fantastic
Version:6.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

We are using Light Fantastic theme on DrupalSouth.net.nz, and backported it to Drupal 5. I think some of the issues we fixed are bugs, so you may want to review the Drupal 6 version and test for the following issues;

  • content doesn't always clear to the right of the secondary tabs
  • $show_messages variable is never set
  • Fieldsets have no border and heirarchy of forms is lost
  • Autocomplete results are not left aligned
  • Typo on div.sidebar_right ul?
  • Links in the additional region are the same color as the background.
  • Links in status messages disappear onhover
  • $language variable is never set
  • $front_page variable is never set
AttachmentSize
backport-drupal5.patch8.47 KB
Login or register to post comments

Comments

#1

Posted by Bevan on September 19, 2008 at 3:00am

Woops, here's the correct link to DrupalSouth http://drupalsouth.net.nz/

#2

Posted by jbrauer on September 30, 2008 at 3:04pm

Hi Bevan... Would you be interested in being a co-maintainer to maintain the Drupal 5 branch?

#3

Posted by Bevan on October 1, 2008 at 4:54am

Hi Joshua,

I'm happy to commit this patch, but unfortunately I wouldn't be able to support or maintain a branch frequently enough to be a responsible maintainer.

Bevan/

#4

Posted by jbrauer on October 6, 2008 at 4:33am
Status:needs review» closed (won't fix)

Hi Bevan,

Thanks. For the time being I'm going to mark this won't fix and we'll leave the patch here for anybody who wants to use it. If somebody has the time to step up as maintainer of a D5 branch then we'll revisit at that point. I'm simply not doing enough D5 dev anymore to make me a good maintainer for a branch.

Thanks,
Josh

#5

Posted by jbrauer on October 6, 2008 at 1:43pm
Status:closed (won't fix)» postponed

Better status to leave this in so it's more easily seen. Same message as before.

#6

Posted by jbrauer on October 14, 2009 at 7:56pm
Status:postponed» closed (fixed)

The 1.x branch is now deprecated and the 2.x branch cannot readily be backported.

#7

Posted by Bevan on October 19, 2009 at 3:32am

Where can I find a summary of the changes in the 2.x branch? Is it just conversion to the Fusion theming framework?

nobody click here