Simple patch removes extra &.

CommentFileSizeAuthor
#6 310724-ahah_helper_2.x_callbyref.patch456 bytesgreg.harvey
#5 310724-ahah_helper_2.x_callbyref.patch0 bytesgreg.harvey
ahah_helper_callbyref.patch4.03 KBheine

Comments

ppblaauw’s picture

ppblaauw commented
Status: Active » Reviewed & tested by the community

Applied this patch.

No "Call-time pass-by-reference has been deprecated" errors anymore.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Thanks Heine! :)

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Version: 6.x-1.0 » 6.x-2.0
Status: Closed (fixed) » Active

Getting this again in 6.x-2.0:

Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /home/gharvey/workspace/cmspros/trunk/www/sites/all/modules/contrib/ahah_helper/ahah_helper.module on line 255

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Status: Active » Needs review
StatusFileSize
new 310724-ahah_helper_2.x_callbyref.patch0 bytes

Patch attached.

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
StatusFileSize
new 310724-ahah_helper_2.x_callbyref.patch456 bytes

Ugh, ignore #5 - forgot to paste the code in to the file from my clipboard. Patch attached HERE.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Was getting the same warnings and applied patch in #6 - which works great.

Thanks!

Rok Žlender’s picture

Rok Žlender commented
Status: Needs review » Reviewed & tested by the community

Worked fine for me too.

burningdog’s picture

burningdog commented

Works for me too.

boombatower’s picture

boombatower commented

Ping.

prosk’s picture

prosk commented

Is it possible to apply the patch on the d6 release?

Thank you !

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

#6 *is* for the D6 release.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented

Patch in #6 does indeed fix the problem.

jefkin’s picture

jefkin commented

Months have passed, with no complaints, (#6 works for me btw) why not push this through?

CODECOWBOY-1’s picture

CODECOWBOY-1 commented

#6 path works for me too - does not seem to be in latest release

BradM’s picture

BradM commented

Confirming patch in #6 needs to be applied to the latest release.

cristhian’s picture

cristhian commented
Status: Reviewed & tested by the community » Fixed

Applied to 6.x-2.x-dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

OliverColeman’s picture

OliverColeman commented
Version: 6.x-2.0 » 6.x-2.1

The fix doesn't seem to have made it into 6.x-2.1.

OliverColeman’s picture

OliverColeman commented
Status: Closed (fixed) » Active
manuel garcia’s picture

manuel garcia commented

Definetly stil happening in 2.1,

manuel garcia’s picture

manuel garcia commented
Status: Active » Fixed

Just checked, this is fixed in the lates dev version, so I assume when the next release is out it will be fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.