The feature that adds a "Rebuild theme registry on every page" checkbox to the theme settings page works.

But while it correctly only fires off a theme registry rebuild once per page request, it mistakenly warns the user an additional number-of-levels-of-basetheme times.

In other words, if you have a subtheme of zen, it will display the warning twice. If you have 3 levels of base/sub themes, you'll get 3 warnings.

I mistakenly only tested this feature on the base theme. And not in a subtheme. Ooops.

CommentFileSizeAuthor
#3 zen_rebuild_message.patch687 bytesscottrigby

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Title: Auto theme-registry rebuild warns themer multiple times » Multilple "The theme registry has been rebuilt" warnings
Status: Active » Fixed

Easily fixed.

http://cvs.drupal.org/viewvc.py/drupal/contributions/themes/zen/zen/temp...

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented
Status: Closed (fixed) » Needs review
StatusFileSize
new zen_rebuild_message.patch687 bytes

John, thanks for this. Works really nicely!

I'm adding a patch, in case this is helpful.

(It's your code, so not sure if 'code needs review', but this is the first patch I've made on my mac, so please let me know if there's any issue with format, etc).

Cheers :)
Scott

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented
Status: Needs review » Closed (fixed)

There are instances even after this patch - such as after logging in, or saving a node - where the message still shows up twice...