Multilple "The theme registry has been rebuilt" warnings

JohnAlbin - September 19, 2008 - 17:14
Project:Zen
Version:6.x-1.0-beta3
Component:Code
Category:bug report
Priority:minor
Assigned:JohnAlbin
Status:closed
Description

The feature that adds a "Rebuild theme registry on every page" checkbox to the theme settings page works.

But while it correctly only fires off a theme registry rebuild once per page request, it mistakenly warns the user an additional number-of-levels-of-basetheme times.

In other words, if you have a subtheme of zen, it will display the warning twice. If you have 3 levels of base/sub themes, you'll get 3 warnings.

I mistakenly only tested this feature on the base theme. And not in a subtheme. Ooops.

#1

JohnAlbin - September 19, 2008 - 17:34
Title:Auto theme-registry rebuild warns themer multiple times» Multilple "The theme registry has been rebuilt" warnings
Status:active» fixed

Easily fixed.

http://cvs.drupal.org/viewvc.py/drupal/contributions/themes/zen/zen/temp...

#2

Anonymous (not verified) - October 3, 2008 - 17:52
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

#3

scottrigby - October 4, 2008 - 16:08
Status:closed» patch (code needs review)

John, thanks for this. Works really nicely!

I'm adding a patch, in case this is helpful.

(It's your code, so not sure if 'code needs review', but this is the first patch I've made on my mac, so please let me know if there's any issue with format, etc).

Cheers :)
Scott

AttachmentSize
zen_rebuild_message.patch687 bytes

#4

scottrigby - October 4, 2008 - 16:23
Status:patch (code needs review)» closed

There are instances even after this patch - such as after logging in, or saving a node - where the message still shows up twice...

 
 

Drupal is a registered trademark of Dries Buytaert.