When I check out a user profile, his name & address appear. That's great!

The phone & fax do not, however.

And I would guess that if I were to add my own fields, say a description of the business, time when the business is open, etc., then it would not work either.

Would you mind to add some callbacks in the theme_addresses() function so we can do that?

And of course, if we want to go banana, we could add in the settings permissions & what is shown in the vCard, that would be for later...

CommentFileSizeAuthor
#1 addresses-fix-phone-in-profile.6.4-1.x.patch1.02 KBAlexisWilke
#1 addresses_phone.inc_.gz304 bytesAlexisWilke

Comments

AlexisWilke’s picture

AlexisWilke commented
Assigned: Unassigned » AlexisWilke
Category: feature » bug
Priority: Normal » Critical
Status: Active » Needs review
StatusFileSize
new addresses_phone.inc_.gz304 bytes
new addresses-fix-phone-in-profile.6.4-1.x.patch1.02 KB

Okay! Found it! I guess it would be neat to have a documentation too. As if I were to write it... 8-)

Anyway, you can edit what is going to be presented to the end user. That's marvelous. Man! Your system is really quite complete!

Now, that did not solve the phone/fax not showing up. You need to add all the theme stuff to make it work. I have a patch and a new file so the phone/fax can appear in the address block.

Thank you.
Alexis Wilke

P.S. I changed this entry from a feature to a bug since missing code is probably more of a bug...

P.P.S. By default, you will use some US address. I think this is fine, and I think you should also check whether the "Default Country" is defined. I think that isn't done. Anyway... the US default includes new-line characters, but the United States country address is defined differently. That's confusing since you may think you're using one when in reality the other is used. So I would suggest that both match by default. Now, this could be because I'm using FCKeditor and that does not see the \n as a <br> tag. And I'm not too sure how we could get that fixed.

     // in countries/us.inc
/**
 * Implementation of hook_address_format().
 *
 * Format the address using local preferences. It uses
 * Token module to convert this tokens to their real values.
 *
 * @return
 *   String. The address field tokens
 */
function addresses_address_format_us() {
  return "!aname
!street
!additional
!city, !province_name !postal_code
!country_name";
}
brmassa’s picture

brmassa commented

Alexis,

I was about to implement a missing feature: divide the address display in two Token texts:
1* the primary one will contain all vCard fields: street, city, etc...
2* a secondary text what would have all non strict-vCard fields, like maps, comments.. AND the primary one.

So, it would be like this (an example):
main token text:

!vcard
!comment
Geo-location: !latitude, !longitude
!map

vCard token text

!aname
!street
!additional
!city, !province_name !postal_code
!country_name

It might add an good customization options, I dont know if it will be too complex for users, but its my idea. You can see it half implemented: the token categories are already there, but i didnt created two different texts to apply them...

regards,

massa

AlexisWilke’s picture

AlexisWilke commented

Massa,

Yes, I have seen the definitions of the tokens. I think it is a great idea.

Internally, we should define another token set called "addresses_ignore" or "addresses_private" for any field that should never ever be displayed in the User Profile area. I created a module for a customer and they want to have some controls that are just and only internal controls. So you can see them in the user editor, but not in the profile.

Obviously, people could use any name anyway, but if we define one in the module, we can make sure that its functionality sticks as described.

Thank you.
Alexis

brmassa’s picture

brmassa commented
Status: Needs review » Fixed

Alexis,

good new! Phone/Fax fields now working fine

regards,

massa

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.