Steps to reproduce:
1. Enable Teaser block.
2. Go to http://ungpirat.6/admin/content/node-type/page
3. Try to change the comment setting.

Expected result:
Ending up on http://ungpirat.6/admin/content/types with a message that says it successfully updated Page.

Result:
I end up on the same page as before (http://ungpirat.6/admin/content/node-type/page), with no setting changed.

Solutions:
For me, the only solution right now seems to be to disable Teaser block.

Comment:
Is this a result of hook_form_alter() or something thelike?

CommentFileSizeAuthor
#4 teaser_block.module.patch497 bytesztyx
#2 form_alter.patch1.03 KBztyx

Comments

ztyx’s picture

ztyx commented
Title: Breaks radio options » Breaks content type editing form

Yes it is infact teaser_block_form_alter(...) that alters the form on http://ungpirat.6/admin/content/node-type/% because it too has the form ID 'node_type_form'.

I will try to roll out a patch pretty soon to fix this.

ztyx’s picture

ztyx commented
Assigned: Unassigned » ztyx
Status: Active » Needs review
StatusFileSize
new form_alter.patch1.03 KB

The problem was the $form['#submit'] attribute that was not correctly set. Attaching a patch that fix it.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Needs work

"Adding an extra field" is nice, but that comment does not provide any valuable information - please optimize.

Also, the additional submit function was added in front of the regular submit function before.

ztyx’s picture

ztyx commented
Status: Needs work » Needs review
StatusFileSize
new teaser_block.module.patch497 bytes

Sure. How is this?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Priority: Critical » Normal
Status: Needs review » Fixed

Thanks, committed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.