Separating Menus

hmm, I haven't yet made it as a selectable option, but if u want only the siblings of the same menu to be closed, use the attached .js

basicly all I did was change this line

var siblings = $('ul.menu li.expanded').not('.own-children-temp').not(':has(#' + id + ')');

into this

var siblings = $(li).parent().find('li.expanded').not('.own-children-temp').not(':has(#' + id + ')');

I'll try to make it into a selectable option and make a proper .patch, but I've never made a .patch in my life so don't expect this withing 10 minutes :x

k, so I tried adding the options n stuff and it seems to work properly

also tried to pack it into a nice .patch file (which was the first time I ever did that so it took me ages to figure it out)

but here goes

this patch should add an option called "Interpret the above option as per-menu" right below the "Keep only one menu open at a time." option
I'm not sure if this would be the best way to describe it but it basically makes open submenus that don't have the same parent as the menu u clicked stay open

when "Keep only one menu open at a time." isn't selected, this option will be ignored.

btw, this is pretty much my first contrib ever... I'm scared :x

yeh, found the problem

I downloaded the dev version off the project page, and made the changes in that, but I made the patch against the CVS repository version

lemme try that again

tbh, I'm just glad some1 tried it :p

k, I made the changes to the right version this time and I changed the head (dunno if I was suppose to)

I like this idea, and it's implemented nicely too! UI-wise, it would be ideal to move this effectively 3-state option into 3 radio buttons rather than 2 checkboxes, but that would require a large amount of additional logic and break the simplicity of the single effects setting. Not really worth it.

Please fix indentation, especially in the JS file. Drupal code convention does not allow \t, but rather uses two spaces for each level of indentation. Once that's done, it can get in!

subscribe

like this?

manually edited it coz I was too lazy to remake the patch

Sorry, the patch isn't applying.

Take my word for it, manually editing a patch so that it still applies is far, far harder than rerolling it.

Found the problem. You're messing with the File $Id$ comments. Leave them alone. CVS will take care of them.

oh ok, lemme try it again

Um, no; the last CVS commit was made back in August. It's been a quiet few months for this module.

I'm fairly sure the DRUPAL-6--3 and HEAD branches are identical right now, too. They ought to be - HEAD isn't chasing D7 yet.

yeh, I just noticed that as I did another checkout ;)

looked at what the patch spit out and it looks like it went proper

Used a better description for this setting, and updated the localization template.

oh yeah, I didn't rly think about translation stuffs :x

senku ^^

Made a CVS ID mistake myself. This patch will apply to HEAD and DRUPAL-6--3.

Committed to HEAD and DRUPAL-6--3.

A stable version will be released pending #280843: More flexibility for enabling/disabling DHTML effect