I'm trying to display related content on my site. I have two content types, i.e. module and forum. There is also a vocabulary which consists of terms created by NAT using module content types. This vocabulary is used for tagging forum topics. So what i want to do to create a block view to be displayed on module pages listing forum topics tagged with the term corresponding to that module. For example, when you go to Views project page, the forum topics tagged with "Views" term will be listed in a block.

Basically, i'll get the node nid from url and load the related node, get its title and pass it as term name. I thought this would be easy but i couldn't make the view work. I created a block view which lists node titles. I also added a Taxonomy: Term argument with the following php argument code:

if (arg(0)=='node' && is_numeric(arg(1)) { $node = node_load(arg(1));
return $node->title;
}

I selected the basic validation as i don't really know what this is. Now when i enter node/1 as arguments to preview, the resulting query do not get the node nid "1" from the argument code. Instead it gets the "node" part and searches for the term "node". Here is the query:

SELECT node.nid AS nid,
   node.title AS node_title
 FROM node node 
 LEFT JOIN term_node term_node ON node.vid = term_node.vid
 INNER JOIN term_data term_data ON term_node.tid = term_data.tid
 WHERE (node.status <> 0) AND (term_data.name = 'node')

How can i make this work? Any suggestions?

Comments

mooffie’s picture

mooffie commented

I also added a Taxonomy: Term argument with the following php argument code:

The code you typed kicks in if the argument is missing. That's why it has "Provide default argument" as its title. If an argument is provided, your code won't run at all.

Now when i enter node/1 as arguments to preview

Once you provide arguments there, your code won't get called. That's because the purpose of your code is to provide a default argument, and in this case it's not needed.

You provided two arguments: "node" and "1". The 'Taxonomy: Term' argument is your first (and probably only) argument, so it gets the "node".

(Besides, even if you code did run: You're using the arg() function, and this function always takes its input from what you see in the browser's address bar. Never from what you type in the "arguments to preview".)

How can i make this work?

I think your code will work as-is if it's in a block. Inside your code you can do drupal_set_message('blah blah'); to help in debugging.

drupaloSa’s picture

drupaloSa commented

You mean instead of using a view for this, i should create a custom php block with the sql query above?

mooffie’s picture

mooffie commented

I think your code will work as-is if it's in a block.

You mean [...] i should create a custom php block

No, no. I meant that your code looked fine to me, and I suggested that you continue with your original plan: to show the *view* in a block (that is, add a 'Block' display and ask Drupal to show it) and everything might possibly be fine.

drupaloSa’s picture

drupaloSa commented

Unfortunately the view block isn't displayed on the module page (eklenti/16/read-more-tweak.html). Devel shows that the following query is executed:

SELECT node.nid AS nid, node.title AS node_title FROM node node LEFT JOIN term_node term_node ON node.vid = term_node.vid INNER JOIN term_data term_data ON term_node.tid = term_data.tid WHERE (node.status <> 0) AND (term_data.name = '') LIMIT 0, 10

As you can see term_data.name check is empty which means there is a problem with the argument. As you've said above, it should be at worst term_data.name = 'eklenti' for this url. Here is my exported view. Perhaps you can find something that i might have done wrong.

$view = new view;
$view->name = 'relatedcontent';
$view->description = 'ilgili yazılar';
$view->tag = '';
$view->view_php = '';
$view->base_table = 'node';
$view->is_cacheable = FALSE;
$view->api_version = 2;
$view->disabled = FALSE; /* Edit this to true to make a default view disabled initially */
$handler = $view->new_display('default', 'Defaults', 'default');
$handler->override_option('fields', array(
  'title' => array(
    'label' => '',
    'link_to_node' => 1,
    'exclude' => 0,
    'id' => 'title',
    'table' => 'node',
    'field' => 'title',
    'relationship' => 'none',
  ),
));
$handler->override_option('arguments', array(
  'name' => array(
    'default_action' => 'default',
    'style_plugin' => 'default_summary',
    'style_options' => array(),
    'wildcard' => 'all',
    'wildcard_substitution' => 'Tümü',
    'title' => '',
    'default_argument_type' => 'php',
    'default_argument' => '',
    'validate_type' => 'none',
    'validate_fail' => 'not found',
    'glossary' => 0,
    'limit' => '0',
    'case' => 'none',
    'path_case' => 'none',
    'transform_dash' => 0,
    'add_table' => 0,
    'require_value' => 0,
    'id' => 'name',
    'table' => 'term_data',
    'field' => 'name',
    'relationship' => 'none',
    'default_options_div_prefix' => '',
    'default_argument_fixed' => '',
    'default_argument_php' => 'if (arg(0)==\'node\' && is_numeric(arg(1)) { $node = node_load(arg(1));
    return $node->title;
    } ',
    'validate_argument_node_type' => array(
      'eklenti' => 'eklenti',
      'poll' => 0,
      'forum' => 0,
      'page' => 0,
      'story' => 0,
    ),
    'validate_argument_node_access' => 0,
    'validate_argument_nid_type' => 'nid',
    'validate_argument_vocabulary' => array(
      '2' => 2,
      '3' => 0,
      '1' => 0,
    ),
    'validate_argument_type' => 'tid',
    'validate_argument_php' => '',
  ),
));
$handler->override_option('filters', array(
  'status' => array(
    'operator' => '=',
    'value' => 1,
    'group' => '0',
    'exposed' => FALSE,
    'expose' => array(
      'operator' => FALSE,
      'label' => '',
    ),
    'id' => 'status',
    'table' => 'node',
    'field' => 'status',
    'relationship' => 'none',
  ),
));
$handler->override_option('access', array(
  'type' => 'none',
));
$handler->override_option('title', 'İlgili Yazılar');
$handler->override_option('style_plugin', 'list');
$handler->override_option('style_options', array(
  'type' => 'ul',
));
$handler = $view->new_display('block', 'Blok', 'block_1');
$handler->override_option('block_description', '');
$handler->override_option('block_caching', -1);
drupaloSa’s picture

drupaloSa commented

I've added a Global: Null (w/ display all values) argument before the Taxonomy: Term in order to get the right argument value for the term name check. Now the preview query makes the term_data.name = '16' check for node/16. However, php argument code (which should turn 16 to a term name) still doesn't work here.

On the live page, the following query is executed which lists all the published nodes as a result in a block: SELECT node.nid AS nid, node.title AS node_title FROM node node WHERE node.status <> 0 LIMIT 0, 10. Again the term name check (i.e. the 2nd argument) is ignored.

According to the views document

Block displays have no source of arguments at all; they cannot pull arguments from the URL, and often require use of the PHP code default in order to get arguments

I don't know why the second argument and its handling code are ignored completely for the live block view.

drupaloSa’s picture

drupaloSa commented

Now i tried to create a custom block and embed the view by adding the argument values directly to the view. I used the following code with the view i gave before. The block seems to work! However, i still wonder why the views block did not work in the first place. Could it be a bug?

<?php
  $node = node_load(arg(1));
  $display_id = 'block';
  $view = views_get_view('relatedcontent');
  $view->set_display($display_id);
  $view->set_arguments(array('node', $node->title));
  print $view->render($display_id);
?>

Btw, is there any difference between these two methods as far as performance is concerned?

mooffie’s picture

mooffie commented
Status: Active » Fixed

Here is my exported view.

I checked it out. It turns out you have a PHP syntax error. You have:

if (arg(0)=='node' && is_numeric(arg(1))

whereas it sould be:

if (arg(0)=='node' && is_numeric(arg(1)))

Except for that, your view works.

So I'm marking this issue 'fixed'.

Btw, is there any difference between these two methods as far as performance is concerned?

I don't think there's any difference.

As for performance in general, it's more efficient to work with terms IDs, not term names. Incidentally, there's a module that provides, as a Views argument, the term ID of the "current" node. I can't search for it because Drupal.Org is sluggish right now. Perhaps you'd want to locate it and prod its author to release a D6 version.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.