Port to Drupal 6.x

here is a patch

i tryed some nodes and it works

great module!!! really great

Patch doesn't apply.

Hi, I applied the patch for v6 manually, as it didn't seem to work properly on the released versions.

In case it might help others, you'll find attached the result in a zip. Code may need review, as I'm not familiar with the project, but so far it seems to work great on my installation (6.8)

Cheers,
Eric

Subscribing!!

thanks for the patches, folks- i'll be looking carefully at these shortly. for the time being, however, i'm focusing on clearing out the remaining issues for D5, and doing a thorough overhaul of the node creation mechanism. once this is relatively stabilized, i'll do a proper D6 port :)

This is cool. I can now create a private forum and work on a website with each one of us commenting on a page! 8-)

And once something was agreed upon, it is in writing 9-)

Thank you!
Alexis

Well... I tested and it does not work at all for me. I checked the .zip and compared a bit with the patch and I just cannot understand how that could possibly work. To add a forum post, you need a call to node/add/forum, but at this time it only calls a comment form and I just cannot see how that would work.

And I get a PHP error when I have no forum defined. It should generate a Drupal error, but not a PHP error!

Thank you.
Alexis

Alright, nevermind, I got it now.

There were several errors in the creation of the new node. Primarily with the author name. There was also a problem with the title. Whoever used $values['title'] instead of $newnode['title']. $values is not defined in there!

I also freely made my own personal change... 8-) The "Discuss This!" message becomes "Continue Discussing This!" when there is a corresponding forum post. That way, I know that someone started a discussion! I would suggest you add two variables for these titles. That way people could choose what they want. Possibly using "Discuss This!" twice.

And in the form where you select the forum for a node type, I added a title. That makes quite a difference! I can see what I'm doing. Strangely, it looks like the order is not the same. I guess the drop downs are not sorted, whereas the checkboxes are (automatically) and since I have 8 node types, there was no way for me to know what was what.

Alright, all that to say, please, take the time stick that as version 6.x-dev so people can start pluging along and report bug!

Trust me, this version works! And that rocks. 8-)

Thank you.
Alexis Wilke

Ha! Ha! Ha!

I found several bugs already. 8-)

So... the delete was not implemented!

I left the last REPLACE and thus nodes/topics weren't attached to each others.

Also, when creating a new forum topic, it would not test whether the user had permission. Somehow, page callbacks do not check the access defined in the menu. This was a small risk since the topic would still be denied access, but somehow could have created millions of nodes without you knowing!

This is fixed in the module attached to this node.

There are still one issue: The name of the author is always "Anonymous".

Please, test, test, test, and let us know whether you have problems (post a message too if you it works great for you, that way the authors will know!)

Note: I noticed that in one of the versions there is a block capability. At this time, I did not try to copy that part.

Thank you.
Alexis Wilke

this is my personal review on your patch.
1. wow :)
2. you could create a discussthis.pages.inc and a discussthis.admin.inc file where you can place the callbacks, this saves some ram

Feature request:
be able to use any contenttyp, not only forum

I'm glad you like it 8-)

Do you have the ability (permission) to put it as the current -dev version? That way many people can test and let us know whether they run into some problems.

The breakup is a good idea, that way we save in RAM and processing when the module is not required for the current content.

I'm not too sure that the content type can be any node type easily. The node type itself is okay, but there is something about forums and taxonomy which we may not be able to replicate reliably with other node types.

Thank you.
Alexis Wilke

Btw,

You can test a live example on my site here:

http://linux.m2osw.com

You have to go to a page first (although you can discuss the front page too.) Choose a page and click on the Discuss This! or Continue Discussing This!

Thank you.
Alexis

Another bug report: The teaser (and probably body) when added to the Forum Body transforms the data to text (i.e. <p> and such will appear as such.)

Just a note to myself I guess.

Okay guys!

I now have got the interface to display properly (as intended by the author(s)). So the selection of the forum is shown below the checkbox and that only if the corresponding checkbox is selected.

I put all the data inside fieldsets. That looks nicer and it makes the checkboxes actually work properly (i.e. the theme was not otherwise being called.) With that the order of the parameters is different from v5 and the default message, title, etc. of the new forum topic are all hidden (i.e. the fieldset is collapsed by default.) It seems to be the right thing to do since in most cases you will setup that part only once, when the node type/forum links may change all the time.

The validation function now works. Note that in v5.x you probably have a bug on that one. The name used was "valudate" (with a 'u' instead of the 'i').

The link has been yet more enhanced. You have one more flag in the settings that let you turn off that feature (just in case...). So now you can see the number of comments. It is shown between parenthesis as in: (1 new/3 total). This way, if you come back to the same website you can see whether you should check out the discussion!

Thank you.
Alexis Wilke

Hi guys,

Today I got some errors when typing in a forum name while creating a new node. The fact is, there is an auto-completion using an SQL order with strings written between double quotes which in PostgreSQL does not work properly.

I created a new tarball with the fix.

Thank you.
Alexis Wilke

Spiderman,

It has been 4 weeks since I last posted here... Any chances we'll get this in the module as a 6.x version?

If you just give me access to the module, I'll be happy to do it.

Thank you.
Alexis Wilke

There is a problem with the previous version that I only now noticed. As is, the link will be followed by robots! Bad robots, unfortunately, will generate a problem (i.e. they will follow the link.) However, good robots will not with this newer version since it adds a rel="nofollow" to the link.

Thank you.
Alexis Wilke

I installed the last version and every time I click on a "Start a discussion" link (doesn't matter as which user-role) the following error message occurs:

"user warning: Duplicate entry '3-151' for key 1 query: INSERT INTO term_node (nid, vid, tid) VALUES (134, 151, 3) in /srv/www/vhosts/XXX/httpdocs/modules/taxonomy/taxonomy.module on line 698."

Can you post in your discussion forum without the Discuss This module?

Thank you.
Alexis Wilke

sorry for the late reply...

yes, there is no problem with the forum...

Okay, this is now closed because I have a version 6.x of the module in the project.

If you still experience problems with something (such as with the forum), please, post a new issue with the problem. That way we can start from a "clean" -dev version instead of some patch/tarball posted here.

Patches always welcome!

Thank you.
Alexis Wilke