Closed (fixed)
Project:
Workflow Fields
Version:
6.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
21 Sep 2008 at 16:44 UTC
Updated:
17 Oct 2008 at 23:53 UTC
If I set for node reference field : show (but not edit) the field, this field is shown in the edit form as a link (like in a node)
If I save the edit form again the field is broken.
I used this field with the token module to generate the node title, so the title is broken, too.
Comments
Comment #1
infojunkieUnfortunately, I wasn't able to reproduce this: it works correctly for me :-(
Can you tell me more about your setup that might give a clue? Are you using the latest 6.x-1.x-dev version?
Comment #2
Micha1111 commentedI'm using Drupal 6.4 and latest dev-Versions of cck,views,workflow, workflow fields and for builing the nodetitle the modules automatic_nodetitle and token.
My nodetype has the following fields:
taxonomy field (select list)
round: Integer 1-9 select list with allowed values
player1: nodereference field (select list => node type player)
player2: nodereference field (select list => node type player)
result: text field (five rows select list with allowed values)
body field: fckeditor dev-Version
the title is build with auto-nodetitle and token with fields [player1] : [player2]
With the workflow module I created three workflow states (set,edited,ok) and set different permissions for three userroles 1-3
OK, it works. But userrole1 should only edit the field "result", if the workflow state is "set"
So I tried to set the permissions with the workflow fields module
I set for userrole1 "visible" and "editable" for the field "result" and for all other fields only "visible", but for the "body field" not visible
What happens, if a user from userrole1 opens the edit form ?
At first, it is not possible to set permissions for the taxonomy field.
The field "round" is shown as a text (with label)
The fields "player1" and "player2" are shown as a link to this nodes (It should be only the fieldtext without link)
The field "result" ist editable => ok
The "body field" is not visible but the FCK-checkbox "show summary as full" is shown with this text and button !!
Now the user enters the result and save the edited node.
The fields "round","player1" and "player2" are empty and the nodetitle is broken
Only the field "result" must be edited in database, not all fields !!
Comment #3
infojunkieThanks for the info.
I was able to reproduce the autonode_title and "show summary as full" problems. I'll work on those.
The fields "round", "player1" and "player2" keep their values after submission. I am using latest dev release of workflow_fields, please make sure you download and use the latest one.
The issue that "player1" and "player2" are shown as links is by design, because that's the way CCK renders them in a similar situation. You can file a separate feature request to let the user choose how to display each field per state.
Comment #4
infojunkieI fixed both autonode_title and "show summary as full" problems. For the title field, make sure you check the visible and editable boxes, that will let autonode_title perform its job correctly. Can you confirm things are working as expected?
Comment #5
Micha1111 commentedI deactivated and deinstalled the old workflow_fields dev-Version
After installing the new dev-Version, I got the following error messages and a blank screen.
Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of call_user_func(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /mnt/web1/31/45/51628845/htdocs/sites/all/modules/workflow_fields/workflow_fields.module on line 221
Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of call_user_func(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /mnt/web1/31/45/51628845/htdocs/sites/all/modules/workflow_fields/workflow_fields.module on line 250
So I can't test it.
Comment #6
infojunkieVery sorry about that. My php.ini was running with allow_call_time_pass_reference = true, which is not good. I now fixed it for the opposite.
Comment #7
Micha1111 commentedOK, the title works now.
first testing body field:
I checked in workflow state "set" all "visible"-checkboxes without the bodyfield and one "editable"-Checkbox for the field "result"
The bodyfield isn't shown in the edit-form (and the checkbox too), so its ok.
But in the other workflow states (including the creation-form), there is only a plain textarea instead the wysiwyg-editor (FCK)
This happens for all userroles.
Comment #8
infojunkieWhat were your settings for other states? If you never saved the state page for other states, then all fields should be enabled by default.
Comment #9
Micha1111 commentedMmh, its a little bit difficult to handle this module without any documentation.
You were right, I checked permissions only for the one state, I needed different permissions.
Now I checked bodyfield permissions for all states (for two roles the same), but for one role the plain textarea is shown and for the other role the FCK
What about permission-settings for the taxonomy-term-field ?
As I mentioned before, I think its not fine to show the node reference fields as links in an edit-form (only in a node or a view).
There should be the same problem with the taxonomy-term field.
In views-module, you can choose link or text as an option.
In an edit-form, the editor never needs a link to the referenced node or taxonomy term.
I think, I expected something different from your module, when I decided to check a "visible"-checkbox in your settings-form.
I thought, this means visible (or not) in the edit-form !
But I investigated, that the field isn't shown in the node-view and in views too, if I don't check "visible".
Could you separate the settings for edit-forms and nodes/views ?
Comment #10
infojunkie> Now I checked bodyfield permissions for all states (for two roles the same), but for one role the plain textarea is shown and for the other role the FCK
I suspect that's an FCK permission. Please check there.
>What about permission-settings for the taxonomy-term-field ?
>As I mentioned before, I think its not fine to show the node reference fields as links in an edit-form (only in a node or a view).
>There should be the same problem with the taxonomy-term field.
>In views-module, you can choose link or text as an option.
>In an edit-form, the editor never needs a link to the referenced node or taxonomy term.
That is debatable, as some people might want a link while others not. Please open a separate feature request to that effect.
>I think, I expected something different from your module, when I decided to check a "visible"-checkbox in your settings-form.
>I thought, this means visible (or not) in the edit-form !
>But I investigated, that the field isn't shown in the node-view and in views too, if I don't check "visible".
>Could you separate the settings for edit-forms and nodes/views ?
Here too, please open a separate feature request to separate settings for viewing and editing.
Comment #11
Micha1111 commentedFCK-Editor permissions !!
My mistake, sorry and thank you for your help.
Comment #12
infojunkieThanks for your patience :-)
Comment #13
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.