HTML tags escaped by aggregator.module [#311511]

Html tags for bold show code in title of aggregator feeds in both block and on the generated page. I allowed the tag which was already included in the settings section of the aggregator module, but it is not rendering any effect on my site at yourautoright(dot)com.

I am using Drupal 6.4 (fresh install) with Zen Theme and the feed is coming from Google blog news.

Any advice would be appreciated

Comment	File	Size	Author
#6	html-code.jpg	41.82 KB	mjasonbaker
#5	html-code.jpg	41.82 KB	mjasonbaker
#5	html.png	45.46 KB	mjasonbaker

Comments

Comment #1

ztyx commented 29 September 2008 at 23:09

Category:

bug

» support

Comment #2

jtrant commented 30 September 2008 at 23:19

Version:

6.4

» 5.6

i have a similar problem with < and > in titles rendering as > and <

Comment #3

ztyx commented 1 October 2008 at 09:12

Maybe it is your feed source you should notify. At least RSS is sent in XML format and should not contain any HTML tags, unless it is wrapped in CDATA.

Comment #4

mjasonbaker commented 1 October 2008 at 15:35

My feed is google news and google blogs. The aggregator module allows for various html tags and allows the following string by default <a> <dd> <dl> <dt> <li> <ol> <ul>.

I would assume that as Drupal allows and includes the  tag by default, then it should render. I also seem to have problems with characters like the """

Here are two examples of what is being rendered in my right column in a block.

Got <b>Lemon</b> - Get Lawyer
Ooog &amp; Moog - Early Warranty Enforcement

Comment #5

mjasonbaker commented 12 October 2008 at 01:55

Title:

Html tags for bold show code in block, but not rendering

» Html tags for bold show code and do not render

Status	File	Size
new	html.png	45.46 KB
new	html-code.jpg	41.82 KB

I have a feed coming from Google Blog News. In the aggregator settings I have removed all the html tags as they were not rendering and now I still have them showing in their code format.

Im not sure what is going on or how to fix this.

Comment #6

mjasonbaker commented 12 October 2008 at 01:57

Version:

5.6

» 6.4

Status	File	Size
new	html-code.jpg	41.82 KB

Title: Html tags for bold show code in block, but not rendering » Html tags for bold show code and do not render

I have a feed coming from Google Blog News. In the aggregator settings I have removed all the html tags as they were not rendering and now I still have them showing in their code format.

Im not sure what is going on or how to fix this.

Comment #7

amalasingh commented 29 October 2008 at 21:12

Same here at tamil.net. I do a lot of stuff with aggregator module and with google. Unfortunately it spoils the beauty of the site.
Can anyone help?

Comment #8

ztyx commented 30 October 2008 at 15:24

Would it be possible for you to attach an example feed that breaks Aggregator module? That way the bug can be reproduced locally and thus become easier to debug.

Comment #9

mjasonbaker commented 31 October 2008 at 00:19

Here is the example of the URL that I am using http://blogsearch.google.com/blogsearch_feeds?hl=en&q=California+Lemon+Law&ie=utf-8&num=10&output=rss

Post 4 & 5 have pictures.

Comment #10

durum commented 20 November 2008 at 08:31

Version:

6.4

» 6.6

Not only for agregetor, but also for page content type, the tags aren't rendered. The problem is about Zen subtheme I have created. When I switch to Garland or another theme, the tags are rendered. But with the Zen subtheme it doesn't work.
Any help appreciated.

Comment #11

seadog commented 26 November 2008 at 22:32

Same issue here: html tags for bold show code in block, but not rendering. I'm using the Ability theme (based on Salamander). Thanks!

Comment #12

durum commented 27 November 2008 at 13:53

I found out that somewhere in my .css files the strong and em clasess were declared as font-weight: normal and font-style:normal. I removed them and it is ok.

Comment #13

seadog commented 5 December 2008 at 07:37

I checked all through my css files, and even removed them from the server. But the problem still exists. The tags still show up in the block. Where else can I look?

Comment #14

durum commented 6 December 2008 at 21:21

COnsider using something like firebug to find out.

Comment #15

pedrochristopher commented 19 December 2008 at 03:53

The big question is - is this a google problem for which we need a workaround, or is google properly using rss features and the aggregator doesn't support the feature yet.

Here's an example of the google blog feed xml:

<?xml version="1.0" encoding="UTF-8"?>
<rss version="2.0" xmlns:opensearch="http://a9.com/-/spec/opensearch/1.1/" xmln
s:dc="http://purl.org/dc/elements/1.1/">
<channel><title>vermont - Google Blog Search</title><link>http://blogsearch.goo
gle.com/blogsearch?hl=en&amp;q=vermont&amp;ie=ISO-8859-1&amp;num=10</link><desc
ription>Google Blog Search Results: &lt;b&gt;1,058,886&lt;/b&gt; results for &l
t;b&gt;vermont&lt;/b&gt; - showing &lt;b&gt;1&lt;/b&gt; through &lt;b&gt;10&lt;
/b&gt;</description><opensearch:totalResults>1058886</opensearch:totalResults><
opensearch:startIndex>1</opensearch:startIndex><opensearch:itemsPerPage>10</ope
nsearch:itemsPerPage>
<item><title>VPR Regional News: Power restored to all but 50 Vt. customers</tit
le><link>http://www.vpr.net/news_detail/83305/</link><description>Thousands acr
oss the Northeast lost power when an ice storm coated the region a week ago. In
 &lt;b&gt;Vermont&lt;/b&gt;, the worst damage was in rural areas of western Win
dham County.</description><dc:publisher>Vermont Public Radio News</dc:publisher
><dc:creator>unknown</dc:creator><dc:date>2008-12-18T23:22:46Z</dc:date></item>
<item><title>&lt;b&gt;Vermont&lt;/b&gt; rejects Personalized tag request: Tag m
ight be offensive &lt;b&gt;...&lt;/b&gt;</title><link>http://james4america.word
press.com/2008/12/18/vermont-rejects-personalized-tag-request-tag-might-be-offe
nsive/</link><description>Shawn Byrne has been fighting this battle in &lt;b&gt

As all can see, the html tags are converted to their url-style equivalents. Is that OK in RSS XML?

Here is an example on one of my sites how this looks with the "basic" results from standard core aggregation:

http://central-america-forum.com/central-america-latest-blogs

(This happens to be set on a customized zen theme, but the garland results are identical.)

I don't think there is a css solution to this. I think it has to be in either stripping out or converting the character codes.

Thanks to all who have been looking into this issue. Any suggestions for where to do the fix?

Comment #16

ultimateboy commented 19 December 2008 at 04:27

Tags within an RSS feed are not valid according to the W3C. Because of this, most feeds will escape any tags before outputting the feed. If you examine the xml of the feed coming from google in #15, you will see something similar to <title>Treasure Returned to Honduras</title>... escaped tags. This is what is being fed to aggregator.module. Never will escaped characters be converted to unescaped characters. In fact, if you look at google's own feed from your example above (link) and examine that in Google Reader, you will see the escaped characters just like what Drupal shows. In my eyes, if Google can't correctly format their own feeds... how should we?!

Comment #17

ultimateboy commented 19 December 2008 at 04:28

Title:

Html tags for bold show code and do not render

» HTML tags escaped by aggregator.module

Fixing title

Comment #18

pedrochristopher commented 20 December 2008 at 00:23

 In fact, if you look at google's own feed from your example above (link) and examine that in Google Reader, you will see the escaped characters just like what Drupal shows. In my eyes, if Google can't correctly format their own feeds... how should we?!

I tried this in google reader and the titles do not have these '' etc characters. I think it has been stripped out by their reader. Are you using google reader?

Comment #19

good_man commented 20 December 2008 at 17:11

Hello,

I set a lot of tags like and

but how can I display inline style (e.g. 'p style="color: red;" ' it'll show only 'p' )?

Comment #20

manjeet commented 22 December 2008 at 21:09

i changed

function aggregator_save_item($edit) {
...
...
}

in aggregator.module for the title of the feed item.

Just replace $edit['title'] with strip_tags($edit['title'])

then remove all items and updates items.

Manjeet

Comment #21

pedrochristopher commented 25 December 2008 at 02:58

Very good, worked for me. Thanks!

For the noobs, btw, you have to edit on line 838 in the INSERT, as specified in post #20.

Then delete/update of data is through admin/content/aggregator

Comment #22

pedrochristopher commented 26 December 2008 at 03:52

for some reason it appears you also have to add the wrapper function in the update in line 831.
guess i'm the noob~!

Comment #23

ainigma32 commented 9 January 2009 at 12:40

Status:

Active

» Fixed

Since there is a workaround posted and the behavior of the aggregator module seems to be by design I'm setting this to fixed.

Feel free to reopen if you think that is wrong.

- Arie

Comment #24

23 January 2009 at 12:50

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

Comment #25

mkogel commented 15 May 2009 at 12:37

Status:	Closed (fixed)	» Active
Issue tags:		+aggregator, +html tags

Aggregating Google Alert RSS
Using theme salamander
Updated the aggregator.module with the strip-tags() as stated in #20 followed by remove/update items
Removed all the allowed HTML tags in the setting.

Now the titles show clean text. HOWEVER, the remaining issue is quotes or double quotes or any other special character. They are displayed as &amp39; and so on.

I am not a coder at all but I can follow some simple examples. There must be a code similar to strip-tags() which can be used to clean up the special characters.

Any suggestions?

Comment #26

mkogel commented 15 May 2009 at 16:14

Status:

Active

» Closed (fixed)

Found the solution to the ' problem.

Read my solution here

http://drupal.org/node/460460#comment-1592644

I had reopened the issue, now closing.

Moreover, I have added target="_blank" and rel="nofollow" attributes in the Item Output template.

If all these changes are made to the module, I think it can be re-released.

Comment #27

drlakshan commented 4 September 2009 at 14:33

Thanks Manjeet,
your post (#20) sorted my problem.

Kudos!
Lakshan

Comment #28

aravindajith commented 13 August 2010 at 19:05

Great solution. Worked for me.
But I am wondering why this issue is there in even the latest Drupal build?

Comment #29

tsaks commented 25 November 2010 at 18:25

Could someone kindly post the full code segment you need to replace from posting #20.

Thanks!

Comment #30

theorichel commented 5 January 2011 at 21:36

It took some experimenting since the directions were poor, but I finally found the real location to put this strip tag thing, I copy the whole chunk of code below, search for strip tag endyou'll find it
function aggregator_save_item($edit) { if ($edit['iid'] && $edit['title']) { db_query("UPDATE {aggregator_item} SET title = '%s', link = '%s', author = '%s', description = '%s', guid = '%s', timestamp = %d WHERE iid = %d", $edit['title'], $edit['link'], $edit['author'], $edit['description'], $edit['guid'], $edit['timestamp'], $edit['iid']); } else if ($edit['iid']) { db_query('DELETE FROM {aggregator_item} WHERE iid = %d', $edit['iid']); db_query('DELETE FROM {aggregator_category_item} WHERE iid = %d', $edit['iid']); } else if ($edit['title'] && $edit['link']) { db_query("INSERT INTO {aggregator_item} (fid, title, link, author, description, timestamp, guid) VALUES (%d, '%s', '%s', '%s', '%s', %d, '%s')", $edit['fid'], strip_tags($edit['title']), $edit['link'], $edit['author'], $edit['description'], $edit['timestamp'], $edit['guid']); $edit['iid'] = db_last_insert_id('aggregator_item', 'iid'); // file the items in the categories indicated by the feed $categories = db_query('SELECT cid FROM {aggregator_category_feed} WHERE fid = %d', $edit['fid']); while ($category = db_fetch_object($categories)) { db_query('INSERT INTO {aggregator_category_item} (cid, iid) VALUES (%d, %d)', $category->cid, $edit['iid']); } It remains indeed strange why this is not committed yet, but then asain, this module cannot handle atom-feeds either, in spite of the claims, and that is a problem that is possibly just as old as this one.

Comment #31

Faucetpay commented 11 December 2022 at 22:45

Version:	6.6	» 10.1.x-dev
Issue summary:	View changes

Blogger Template Free

Comment #32

hghwqijeq commented 8 June 2023 at 15:40

HTML tags escaped by aggregator.module

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Comment #23

Comment #24

Comment #25

Comment #26

Comment #27

Comment #28

Comment #29

Comment #30

Comment #31

Comment #32

News items

Our community

Documentation

Drupal code base

Governance of community