Download & Extend
Hashcash » Issues

Hashcash updated for Drupal 6.x - code review needed

Posted by ergophobe on September 22, 2008 at 1:00am
Project:Hashcash
Version:5.x-1.4
Component:Code
Category:support request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I just created an updated version of Hashcash and got rid of all minor and major notices issued by the coder module.

I also updated the intall to use the new hook_schema() intall method.

It seems to be working on my site just fine (no crashes). It will take a few days to see if it stops the spam flood, but a hashcash plugin on Wordpress sites I've done just killed spam pretty much right away.

Here is a zip archive of the 6.x module. Sorry it's not a true patch, but you should be able to just do a diff locally and generate a patch.

AttachmentSize
hashcash.zip11.46 KB
Login or register to post comments

Comments

#1

Posted by ergophobe on September 28, 2008 at 12:47am

Forget it - many problems with that code. Some fixed, but still having trouble actually getting the onsubmit event to fire for some reason.

#2

Posted by ergophobe on September 28, 2008 at 4:51am

Okay I think I've got it working now. Sorry about that first one.

AttachmentSize
hashcash-6.x-1.4-alpha.zip 10.88 KB

#3

Posted by grendzy on January 2, 2009 at 5:27pm

subscribing, thanks for the patch. I'll try to review it soon. I'm interested in this module as an approach to #117056: Protection against brute force login.

#4

Posted by grendzy on January 14, 2009 at 11:44pm

Your updated module works great for me! I have a couple of minor suggestions:

  • LICENSE.txt isn't needed (actually I think it will be blocked by Drupal CVS servers).
  • Also, the "version", "project", and "datestamp" lines should be omitted from the .info file (they will be added by drupal.org).
  • There was an extra "onsubmit", though commented out
  • Default form IDs don't match D6 (should be "user-login" and "user-login-form")
  • As long as you're making style tweaks, there are several more formatting changes suggested by coder in "minor" mode (trailing spaces, etc)

On the whole, a well done port. Thanks!

#5

Posted by sdrycroft on February 4, 2009 at 1:06pm
Status:needs review» fixed

A D6 version has been released. The official version fixes the cache issue previously mentioned on this module's front page.

#6

Posted by ergophobe on February 11, 2009 at 8:17pm

Thanks for the notes grendzy and thanks even more sdrycroft for doing a real D6 version.

#7

Posted by System Message on February 25, 2009 at 8:20pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.