Hi Massa,

I think that you should use only one callback name for all the features. At this time, you have two and one of them is not properly named (my taken...)

In the save function (addresses/addresses_user/addresses_user.inc)

    // Let other modules change the standard behaviour
    module_invoke_all('addressapi', 'save', $addr);

I suggest we change this one to addressesapi instead.

And since there is always an operator, we may just want to rename the other one addressesapi too (instead of addressesfieldapi). That's less important though.

Thank you.
Alexis

CommentFileSizeAuthor
addresses_user-fix-callback-name-6.4-1.x.patch458 bytesAlexisWilke

Comments

brmassa’s picture

brmassa commented
Status: Active » Fixed

Alexis,

commited.

BTW: i tried to add you as a co-maintainer but you dont have the CVS account here on Drupal.org. Ask the drupal.org maintainers to allow you commit on CVS. Send them this page URL so they will see that im asking you to join the module dev team.

regards,

massa

AlexisWilke’s picture

AlexisWilke commented

Massa,

I already sent a request yesterday. Did you create a module named "Addresses: External API" or something like that? I'm not too sure how to communicate with them, and I asked them to create a module named "Addresses Extras". On the other hand, it looks like they don't actually create the project, only a CVS account.

Thank you.
Alexis

brmassa’s picture

brmassa commented

Alexis,

nice! but i cant find your CVS username. "alexis" is another guy. And yes, you must create the projects, going to "Create content" on the right. Tell me when you are done.

when i created "Addresses: External API" i was thinking about to integrate Google Contacts, Plaxo and other address/contact APIs. But i didnt have the time to start. hehe

regards,

massa

AlexisWilke’s picture

AlexisWilke commented

Massa,

Okay! I finally created the Addresses Extras project and CVS.

http://drupal.org/project/addresses_extras

My CVS name is "alexiswilke". 8-) That's a more unique name than just alexis.

Do you want to add other sub-modules too? I could give you access to the addresses_extras CVS.

Thank you.
Alexis Wilke

brmassa’s picture

brmassa commented

Alexis,

you were added on Addresses module's dev team. Let's work to fix all those bugs we found!

regards,

massa

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.