I've made some modifications of this module on behalf of a customer I'd like to share.

There's two issues adressed by this patch:

a) revision_moderation_nodeapi calls drupal_set_message about four or five times for every pageview of node with pending revisions. In some themes, this is rendered strangely, since each message can be styled with it's own box.
Instead of this approach, I collect the links in an array which gets passed to theme_item_list and appended to the end of the regular message.

b) There's no direct link to the diff view between the published revision of a node and the one you're currently viewing. I've added one using the same approach as described above.

I hope you'll find this worthy of inclusion – it certainly made my users happier.

CommentFileSizeAuthor
revision_moderation.module-usability-1.patch3.87 KBmikl

Comments

toemaz’s picture

toemaz commented

Just read through the patch. It gets a +1 from me although I have not tested it yet.

add1sun’s picture

add1sun commented
Status: Needs review » Fixed

Seems reasonable to me since it is one message to the user with a list of options they can do. I'd rather keep all of the diff module integration in its own thread though, so I am not committing that part of this patch. I've referred that thread back here to have a peak at the code in the patch though.

Committed to 6, HEAD and 5.

add1sun’s picture

add1sun commented

The diff thread is here: #306033: Improved support for Diff module

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.