Attribute Properties in openid_ax_attributes

sanduhrs - September 23, 2008 - 14:29
Project:OpenID Attribute Exchange Implementation
Version:6.x-2.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:anshuprateek
Status:needs review
Description

It would be easier to work with the attribute properties, if we collected all the defined values [1].

Patch attached with updated install file and much more descriptive openid_ax_persona_form.
I omitted the upgrade path, as this module is still in alpha.
Please review.

[1] http://openid.net/specs/openid-attribute-properties-list-1_0-01.html

AttachmentSize
openid_ax_persona_data_0.patch21.94 KB

#1

anshuprateek - September 23, 2008 - 16:57

the patch seems to ve been worked out for openid_ax.pages.inc,v 1.8. The latest is 1.13. Will check it up against the latest version though.

#2

anshuprateek - September 23, 2008 - 17:03
Assigned to:Anonymous» anshuprateek

#3

sanduhrs - September 23, 2008 - 20:44

Patching against HEAD, now.

As so much has changed from the UI point of view since alpha3, I simplified the patch a bit, to only provide the attributes data.
And will leave the UI optimization for the future ;)

Please review.

AttachmentSize
openid_ax_persona_data_1.patch 21.2 KB

#4

sanduhrs - October 2, 2008 - 12:11
Version:6.x-1.2-alpha3» 6.x-2.x-dev

Still applies fine to latest dev version.

#5

darren.ferguson - October 9, 2008 - 21:30

Yes, i was thinking along the same lines for this one due too the fact that you might want to display this information to users so they can make a choice on what is transferred and sometimes the short name is not descriptive enough for users to understand.

#6

darren.ferguson - October 10, 2008 - 17:26

Have updated the patch to include section in the database table, this is for the view purposes when looking at the persona in the user tab. Have altered that code so it will display in fieldsets. This will do away with the submit button every 10 fields and allows us to group the same or similar fields together to make it much more user friendly to the users.

The patch is attached.

AttachmentSize
openid_ax.install.patch 24.24 KB
 
 

Drupal is a registered trademark of Dries Buytaert.