It would be easier to work with the attribute properties, if we collected all the defined values [1].
Patch attached with updated install file and much more descriptive openid_ax_persona_form.
I omitted the upgrade path, as this module is still in alpha.
Please review.
[1] http://openid.net/specs/openid-attribute-properties-list-1_0-01.html
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | openid_ax.install.patch | 24.24 KB | darren.ferguson |
| #3 | openid_ax_persona_data_1.patch | 21.2 KB | sanduhrs |
| openid_ax_persona_data_0.patch | 21.94 KB | sanduhrs |
Comments
Comment #1
anshuprateek commentedthe patch seems to ve been worked out for openid_ax.pages.inc,v 1.8. The latest is 1.13. Will check it up against the latest version though.
Comment #2
anshuprateek commentedComment #3
sanduhrsPatching against HEAD, now.
As so much has changed from the UI point of view since alpha3, I simplified the patch a bit, to only provide the attributes data.
And will leave the UI optimization for the future ;)
Please review.
Comment #4
sanduhrsStill applies fine to latest dev version.
Comment #5
darren.ferguson commentedYes, i was thinking along the same lines for this one due too the fact that you might want to display this information to users so they can make a choice on what is transferred and sometimes the short name is not descriptive enough for users to understand.
Comment #6
darren.ferguson commentedHave updated the patch to include section in the database table, this is for the view purposes when looking at the persona in the user tab. Have altered that code so it will display in fieldsets. This will do away with the submit button every 10 fields and allows us to group the same or similar fields together to make it much more user friendly to the users.
The patch is attached.