Coding standards [#312320]

Please stick to the coding standards [].
Coder found 1 projects, 4 files, 1 critical warnings, 415 normal warnings

Comment	File	Size	Author
#15	patch_applied.png	82.27 KB	himanshu_jhaloya
#13	coding-standard-issue-fixed-312320-13.patch	62.17 KB	dineshkumarbollu
#6	openid_ax.inc_.patch	21.01 KB	darren.ferguson
#5	openid_ax.module.patch	2.87 KB	darren.ferguson
#4	openid_ax.inc_.patch	21.01 KB	darren.ferguson
#4	openid_ax.install.patch	10.18 KB	darren.ferguson
#4	openid_ax.module.patch	2.22 KB	darren.ferguson
#4	openid_ax.pages_.inc_.patch	19.87 KB	darren.ferguson
#1	openid_ax_coding_standards_0.patch	50.26 KB	sanduhrs

Issue fork openid_ax-312320

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

312320-coding-standards compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

sanduhrs

he/him

German

🇪🇺 Heidelberg, Germany, Europe

commented 23 September 2008 at 20:25

Status	File	Size
new	openid_ax_coding_standards_0.patch	50.26 KB

Updating coding standards.

Attached is a patch against HEAD, please review.

Comment #2

sanduhrs

he/him

German

🇪🇺 Heidelberg, Germany, Europe

commented 23 September 2008 at 20:25

Status:

Active

» Needs review

Status update.

Comment #3

sanduhrs

he/him

German

🇪🇺 Heidelberg, Germany, Europe

commented 2 October 2008 at 12:10

Version:

6.x-1.2-alpha3

» 6.x-2.x-dev

Applies fine to latest dev version.

Comment #4

darren.ferguson commented 9 October 2008 at 21:22

Status	File	Size
new	openid_ax.pages_.inc_.patch	19.87 KB
new	openid_ax.module.patch	2.22 KB
new	openid_ax.install.patch	10.18 KB
new	openid_ax.inc_.patch	21.01 KB

Created the patches for each individual file in the module and went through line by line to make it follow the drupal coding standard. This is against the latest cvs contributions that was checked out about 1 hour ago.

Comment #5

darren.ferguson commented 9 October 2008 at 21:27

Status	File	Size
new	openid_ax.module.patch	2.87 KB

Adding the hook_xrds from http://drupal.org/node/312501 to the module patch.

Comment #6

darren.ferguson commented 10 October 2008 at 17:38

Status	File	Size
new	openid_ax.inc_.patch	21.01 KB

Adding the openid_ax.inc file to this one since this now brings the module up to the drupal coding standards.

Comment #7

anarcat commented 21 March 2009 at 21:55

Status:

Needs review

» Needs work

Can you provide a complete patch, in a single file? I'm not sure which patch to test now.

I do agree that the code needs a cleanup however and this should probably be committed sooner than later to avoid chasing other patches all the time.

Comment #8

darren.ferguson commented 28 March 2009 at 12:01

After receiving nothing on this i gave up with the module and now have a fully open id suite of modules for drupal.

Openid Provider AX, OpenID Provider SREG, Openid Provider Persona, OpenID Client AX, Client Sreg OpenID CP Fields (content profile fields) and OpenID Client Domain (for allowing direct access).

If you would like to use OpenID i would suggest looking at these but as for this module i have not looked at it since October the last patch and will not be using it since it did not meet the needs of what we required.