Posted by sanduhrs on September 23, 2008 at 3:21pm
| Project: | OpenID Attribute Exchange Implementation |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
Please stick to the coding standards [].Coder found 1 projects, 4 files, 1 critical warnings, 415 normal warnings
Comments
#1
Updating coding standards.
Attached is a patch against HEAD, please review.
#2
Status update.
#3
Applies fine to latest dev version.
#4
Created the patches for each individual file in the module and went through line by line to make it follow the drupal coding standard. This is against the latest cvs contributions that was checked out about 1 hour ago.
#5
Adding the hook_xrds from http://drupal.org/node/312501 to the module patch.
#6
Adding the openid_ax.inc file to this one since this now brings the module up to the drupal coding standards.
#7
Can you provide a complete patch, in a single file? I'm not sure which patch to test now.
I do agree that the code needs a cleanup however and this should probably be committed sooner than later to avoid chasing other patches all the time.
#8
After receiving nothing on this i gave up with the module and now have a fully open id suite of modules for drupal.
Openid Provider AX, OpenID Provider SREG, Openid Provider Persona, OpenID Client AX, Client Sreg OpenID CP Fields (content profile fields) and OpenID Client Domain (for allowing direct access).
If you would like to use OpenID i would suggest looking at these but as for this module i have not looked at it since October the last patch and will not be using it since it did not meet the needs of what we required.