Attaching files with [#?]-characters results in broken link

movin

I don't have the time to investigate this now, but I suspect this is a bug in either the core upload module or the comment_upload module, since that's what project_issue uses to handle uploads.

thx

The bug is in file_create_url(), and that function hasn't changed in HEAD, so though I haven't tested I would expect this to also be a problem in HEAD. Therefore, I'm changing the version so that we can get it fixed in HEAD and then backport.

I confirmed that this problem exists in HEAD as well.

Unfortunately, the patch in #8 does not fix the problem in all cases, specifically when clean_urls are *enabled* on a site. This is because drupal_urlencode() returns different values depending on whether or not clean_urls are enabled.

function drupal_urlencode($text) {
  if (variable_get('clean_url', '0')) {
    return str_replace(array('%2F', '%26', '%23', '//'),
                       array('/', '%2526', '%2523', '/%252F'),
                       rawurlencode($text));
  }
  else {
    return str_replace('%2F', '/', rawurlencode($text));
  }
}

If in the patch I replaced drupal_urlencode() with a call to urlencode(), I get the correct behavior both when clean_urls are enabled or disabled.

To test I am just creating a text file named #test.txt, and uploading that as an attachment to a page node. Without any patch, clicking on the download link on the node leads to a page not found error. With the patch in #8 applied, when clean_urls are enabled I still get a page not found, but when they are disabled I get the actual text file itself.

see #238299: file_create_url should return valid URLs