Posted by webchick on September 23, 2008 at 7:50pm
Jump to:
| Project: | Service links |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Reading the code in theme_service_links_build_link is challenging because there's stuff in there like:
<?php
switch (variable_get('service_links_style', 1)) {
case 1:
...
case 2:
...
case 3:
...
}
?>It'd be easier to grok if it was:
<?php
switch (variable_get('service_links_style', SERVICE_LINKS_STYLE_TEXT)) {
case SERVICE_LINKS_STYLE_TEXT:
...
case SERVICE_LINKS_STYLE_IMAGE:
...
case SERVICE_LINKS_STYLE_IMAGE_AND_TEXT:
...
}
?>
Comments
#1
#2
fixed long time ago and available from 2.0
#3
Automatically closed -- issue fixed for 2 weeks with no activity.