Support for timezones

mgenovese - September 24, 2008 - 02:56
Project:Timeline
Version:6.x-2.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

First off, thank you for creating this module. Well done.

Second, I know about the GMT issue with this MIT code. That said, when I created a view to capture all event nodes, the placement of the node on the timeline is incorrect; it's being placed with the GMT time, which is being reported as the real GMT. This is probably best illustrated with an example from my site:

I'm in US Central time zone (GMT-5), and my site timezone config is setup as such. I have an event node with a start/end date of 23-Sep-08, start/end time 6-8pm. In the timeline view I created, and after clicking on the the node's pop-up window, it says at the bottom:

Tue, 23 Sep 2008 23:00:00 GMT
Wed, 24 Sep 2008 01:00:00 GMT

and the placement of that bar on the timeline is indeed straddling 23-Sep thru 24-Sep. Clearly incorrect w.r.t. the actual time of the event in Central Time. If I add 5 hours to the start/end time to shift back to GMT, that puts me at 23:00 to 01:00.

I'm using Drupal 5.10, and the released Timeline module 5.x-1.0, with Timeline JS code version 1.2 from MIT. Using Event module 5.x-1.x-dev.

#1

xamanu - August 18, 2009 - 03:39
Title:Timeline times are wrong» Support for timezones
Version:5.x-1.0» 6.x-2.x-dev
Category:bug report» feature request

targeting 2.x branch.

There is no proper timezone handling implemented. This is a good and necessary feature that has to be done soon.

#2

dajjen - August 26, 2009 - 13:21

Thanks for a great module, it's to bad my events popping up in the timeline 2 hours wrong cause of the time formating.
this should get better in future release.

Best regards/
Dajjen

#3

xamanu - August 27, 2009 - 01:03

There is a rudimentary support for timezones implemented in the 6.x-2.0-beta2 version of the timeline module (Commit #256554). Please be aware that it respects drupal's global timeline settings and will not respect settings defined by the cck field or views.

#4

xamanu - August 27, 2009 - 01:08
Status:active» fixed

#5

dajjen - August 27, 2009 - 08:13

Hi.
what do you mean by it respects drupal's global timeline settings?
I can't find any timezone settings in admin/settings/timeline.
The only timezone settings i know of is site's timezone and user timezone, do timeline take respect of this?

Best regards/
Dajjen

#6

xamanu - August 27, 2009 - 17:26

This is exactly what I've meant (site's default timezone or user-configurable time zones). Configurable at admin/settings/date-time

There are also cck date field settings on "Time zone handling". These aren't supported for now.

#7

System Message - September 10, 2009 - 17:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.