Hi,
when you call drupal_verify_install_file with the flag FILE_READABLE for a nonexistant, in a call by drupal_verify_install_file a php function is called which issues a warning for the nonexistant file. file_exists() is used in previous code, but in a way which makes it senseless...
The attached file return immediatly false if the file isn't of the expected type or doesn't exist. This check is entirely performed by the is_xx()-func.
The old misbehauvior needed to subsequent calls to drupal_verify_install_file which are unneeded.

CommentFileSizeAuthor
#12 inc_install_drupal_install_fix_file.patch810 bytesCorniI
#10 inc_install_drupal_install_fix_file.patch909 bytesCorniI
#7 inc_install_drupal_install_fix_file.patch738 bytesCorniI
#5 inc_install_drupal_install_fix_file.patch737 bytesCorniI
#1 install.inc-drupal_verify_install_file.patch4.06 KBAnonymous (not verified)
drupal_ver_install.patch679 bytesCorniI

Comments

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new install.inc-drupal_verify_install_file.patch4.06 KB

I think we need to retain the $return and make the changes I have attached.

catch’s picture

catch
he/him
Primary language English
commented

Not tested the patch yet, but this is to prevent errors if you mv default.settings.php instead of cp default.settings.php since the installer requires both default.settings.php and settings.php to actually work.

CorniI’s picture

CorniI commented

Nah, it's not the real patch, it's a bug I found when writing that patch ;)
The one of earnie doesn't work. I maybe have to explain better where the problem really lies: Even when a file doesn't exist drupal calls drupal_install_fix_file() for the file, which issues a call to fileperms() which then issues a stat failure:
Warning: fileperms() [function.fileperms]: stat failed for ./sites/default/default.settings.php in /var/www/drupal7/includes/install.inc on line 740
One may want to fix the problem there, too. But if a file is nonexistant most of the loop in drupal_verify_install_file is nonsense, too. The only logical thing (for me) would be passing a dir to the drupal_install_mkdir() and FILE_EXIST, the rest would just leed to failure-calls to is_xxx() and drupal_install_fix_file()

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

So what you really need is to return FALSE if the file doesn't exist in drupal_install_fix_file.

CorniI’s picture

CorniI commented
Status: Needs work » Needs review
StatusFileSize
new inc_install_drupal_install_fix_file.patch737 bytes

here we go...
I'll look at drupal_verify_install_file another day :)

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

Watch those tabs. You need spaces.

CorniI’s picture

CorniI commented
StatusFileSize
new inc_install_drupal_install_fix_file.patch738 bytes

here we go again...

CorniI’s picture

CorniI commented
Status: Needs work » Needs review

and I forgot to change the status

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community
CorniI’s picture

CorniI commented
StatusFileSize
new inc_install_drupal_install_fix_file.patch909 bytes

I forgot a space, and added a comment by webchick's request. i'm not sure if she'll commit this as-is, but we'll see :D

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

That one line comment is definitely over 76 characters long.

CorniI’s picture

CorniI commented
Status: Needs work » Needs review
StatusFileSize
new inc_install_drupal_install_fix_file.patch810 bytes

That Comment wasn't good, anyway

CorniI’s picture

CorniI commented
Status: Needs review » Fixed

webchick comitted this one, thanks!
Now just someone need to review #312144: Install fails when default.settings.php is not present ;)

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.