Dear Michelle,

In my CVS waiting your approval to the following
module contribution:- in colaboration with contributer of advanced froum module
-title: advanced forum-phpbb3 version 5.x
- type: fix-bugs
- New features/ fixes:
- fix width bug in IE6
- Better gui
- improved online status style
- improved topic list and forum list presentation
- increase compatibility of contributed theme ( phpbb3 )
- requirements: forum core module
- built on: advanced forum 5.x
- installation documentation: copy the zip file to your main modules directory ( /modules) and unzip it there. go to module administration in your browser and enable the module.
- snapshots:
1) http://kuwait-md.org/2.JPG
2) http://kuwait-md.org/3.JPG
3) http://kuwait-md.org/4.JPG
- module zip file
http://www.kuwait-md.org/advanced_forum-%20PHPBB%20version.zip

- Collaboration info:
Module stays under the name of Michelle
a new version of the module/ update one is created with the fixes
or a different version is made available under the name advanced forum module PHPBB3 version
Update the 6.x version with the new theme files( advforum folder) and check compatability

Please comment to this and approve it a.s.a.p. for my CVS application to get accepted;
sincerely,
Bisher

CommentFileSizeAuthor
advanced_forum- PHPBB version.zip139.16 KBq8doc

Comments

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Component: Contrib integration » Styles
Status: Active » Fixed

I saw your application and ajk said he was responding to it. You don't need a CVS account to submit a style for AF. You just need to attach it to an issue. You will need to work off the current code, though. The changes are too great for a style based off the old code to be usable to me. If you're willing to redo it, I suggest using the "naked" style as a base. Also, don't submit a whole zip of everything. I only need the style directory.

Michelle

q8doc’s picture

q8doc commented

ok no prob, i will remove the AF part from my CVS.

here is a link to the style only folder,

though i didn't really understand what you meant, but yes i can rebuild the whole module, but basically the style will be phpbb like, which is nice, but what about your old style...???

The fixes i introduced can be also done on your style. so basically, we can end up with a module having two styles in it ...

So you can have your AF in drupal style, which i plan to make
the default style that you already have there
and phpbb3 forum style, which i already did... and you can include that in the documentation for the user to choose from the directories to paste.... or make three versions of the module...

What do you think!!
Sincerely,
Bisher

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

As I said, this is based on the old theme code. I don't have time to convert it to the new style system. If you want to do that and submit a new style, that's up to you. There aren't any docs, yet, on submitting styles but you can base it off the latest naked style.

Michelle

q8doc’s picture

q8doc commented

By style you mean theme.. or the actual style that AF module uses...
From what i understood there no need to change anything in your original code only the style( advforum) directory.

you can just add two more directories that users can choose from to change their AF module style, may be add a function to choose the style in the administration pages.

If you don't have time, which i can clearly see, you can add me as a collaborator to the module, i really hope i can develop this module more and more.

If i dont seem to get you, please elaborate more to me, i would really appreciate that.

Bisher

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

No, by style I mean style. A style is a set of templates, css files, and images put together in a directory. Looking at your screenshots, you are basing yours off old code. I don't have time to update your style to use the latest code. If you would like to update your style and contribute it, that's great. But it needs to work with the latest code and follow Drupal's coding standards. I'm not sure how much clearer I can make that, honestly. I appreciate that you want to contribute but I'm already stretched for time and can't take on something that will require a lot of work from me to fix up.

Michelle

q8doc’s picture

q8doc commented

No prob, no i see what you mean ... thank you
Bisher

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.